Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata refresh, some minor updates, removal of ocaml 4.13.1 #681

Merged
merged 19 commits into from
Jul 26, 2024

Conversation

psafont
Copy link
Member

@psafont psafont commented Jun 13, 2024

The metadata updates need to be tested before merging, they changed where the files are hosted. Maybe we can do the same for our patches? It will deduplicate the patches we have for rpclib

As always, it's better to review the commits one by one.

@psafont
Copy link
Member Author

psafont commented Jun 13, 2024

The current failure is because of a test in xapi not being attached to any package, fixed by: xapi-project/xen-api#5684

@@ -2,7 +2,10 @@ opam-version: "2.0"
name: "ocaml-base-compiler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we on 4.14.2? Should we drop 4.14.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, eventually, some people might not have updated their opam switches to ocaml 4.14.2, which means bad things will happen when the version is removed.

Copy link
Contributor

@edwintorok edwintorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about dropping 4.14.1

@psafont
Copy link
Member Author

psafont commented Jul 24, 2024

Results on suite run 4060652 are all green

Minor changes, enhances destructing and fixes some small issues

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Removes dependency to cstruct

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: adds location to JSON5 parser errors

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Now there files are hosted in an external repo, and there's a package
per architecture

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor update, v6 types are immutable now, added some convenience
functions

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Removes some extensions, delegates quite a bit to ppxlib now

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor, ported to ppxlib

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor fixes

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: add let operators, and other minor additions

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This was held off for 2 years because of the outdated build of curl
used, with 8.6.2 in the distribution, this version should work again

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Now the files are hosted in an external repo

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: test for autoconf availability has changed

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: update for conduit-mirage (which we do not package)

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Breaking: the rng initialization functions have changed interface

EC crypto has been sped up massively, but it's not used in xapi.

Now the rng for the lwt monad has been split off, but it's not used in
xapi.

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
When producing the cache, opam for some packages does not create files
for all the hashes.

When installing the packages, opam only tries the first hash before
trying to download a package, not all of the hashes.

The combination of both makes makes the rpm builds to fail when these
are properly isolated.

I've seen this happen only for these two packages.

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
wget fails horribly on fedora 40

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
@psafont psafont merged commit 125afe5 into xapi-project:master Jul 26, 2024
1 of 3 checks passed
@psafont psafont deleted the up branch July 26, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants