Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error if multiple by's are used with Ellipsis #149

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Raise error if multiple by's are used with Ellipsis #149

merged 3 commits into from
Sep 22, 2022

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Sep 21, 2022 •
edited
Loading

can you open a separate PR to raise an error here when len(by) > 1

Originally posted by @dcherian in #144 (comment)

@Illviljan Illviljan mentioned this pull request Sep 21, 2022
Merged
dcherian
dcherian reviewed Sep 22, 2022
View reviewed changes
@dcherian dcherian enabled auto-merge (squash) September 22, 2022 16:58
@dcherian
Copy link
Collaborator

Thanks @Illviljan much appreciated!

@dcherian dcherian merged commit af3e3ce into xarray-contrib:main Sep 22, 2022
dcherian added a commit that referenced this pull request Oct 9, 2022
@dcherian
Merge branch 'main' into allow-dtype
08dff04 
* main:
  Update ci-additional.yaml (#167)
  Refactor before redoing cohorts (#164)
  Fix mypy errors in core.py (#150)
  Add link to numpy_groupies (#160)
  Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#159)
  Use math.prod instead of np.prod (#157)
  Remove None output from _get_expected_groups (#152)
  Fix mypy errors in xarray.py, xrutils.py, cache.py (#144)
  Raise error if multiple by's are used with Ellipsis (#149)
  pre-commit autoupdate (#148)
  Add mypy ignores (#146)
  Get pre commit bot to update (#145)
  Remove duplicate examples headers (#147)
  Add ci additional (#143)
  Bump mamba-org/provision-with-micromamba from 12 to 13 (#141)
  Add ASV benchmark CI workflow (#139)
  Fix func count for dtype O with numpy and numba (#138)
dcherian added a commit that referenced this pull request Oct 17, 2022
@dcherian
Merge branch 'main' into numbagg
fea47a5 
* main: (29 commits)
  Major fix to subset_to_blocks (#173)
  Performance improvements for cohorts detection (#172)
  Remove split_out (#170)
  Deprecate resample_reduce (#169)
  More efficient cohorts. (#165)
  Allow specifying output dtype (#131)
  Add a dtype check for numpy arrays in assert_equal (#158)
  Update ci-additional.yaml (#167)
  Refactor before redoing cohorts (#164)
  Fix mypy errors in core.py (#150)
  Add link to numpy_groupies (#160)
  Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#159)
  Use math.prod instead of np.prod (#157)
  Remove None output from _get_expected_groups (#152)
  Fix mypy errors in xarray.py, xrutils.py, cache.py (#144)
  Raise error if multiple by's are used with Ellipsis (#149)
  pre-commit autoupdate (#148)
  Add mypy ignores (#146)
  Get pre commit bot to update (#145)
  Remove duplicate examples headers (#147)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Illviljan @dcherian