method
heuristics: Avoid dot product as much as possible
#347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted another possible optimization
xref #346
Annoyingly
![image](https://private-user-images.githubusercontent.com/2448579/317004574-192d6226-5625-4632-8776-6ab04983ffff.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDAyMjcsIm5iZiI6MTczOTMzOTkyNywicGF0aCI6Ii8yNDQ4NTc5LzMxNzAwNDU3NC0xOTJkNjIyNi01NjI1LTQ2MzItODc3Ni02YWIwNDk4M2ZmZmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDU1ODQ3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWJiMjc1MGYzY2MzZjQ5ZTBjOGMwOWM3OTIyOTdiYjljOTAwZjRmYzAxOTRhZmFmYTcyMGMyYzNkYjEyN2ZjOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.vensa5482yi4vCd1eRqQnDklfXbo0q3bnCjLIWMqU_Y)
asv
is broken and not running now but in a notebook:Even better now since we can use
sparsity(bitmask)
as a proxy instead ofsparsity(containment)
This avoids an expensive sparse matrix dot product whenbitmask
isn't particularly sparse: