Set up doc structure, add @benbovy's gist, add tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbovy
reviewed
Jun 27, 2020
There was a problem hiding this comment.
Looks great!
We'll need to add a few more tests (could be done later):
- test the
XoakAccessorindex property - test non-transformed coordinate values (perhaps with other data than geo coordinates)
- test NN lookup tolerance
- check that the order of coordinate labels in the returned selection is preserved (I checked this locally simply by inspecting the results and it works)
- shallow test for the
DataArray.xoakaccessor
|
I'd prefer merging this soon (maybe after CI is added), because then, the general repo structure is fixed and we can work on different aspects of the ToDo's you listed in separate PRs. |
|
Ok! Can I merge this now? :-) |
benbovy
approved these changes
Jun 27, 2020
|
Yes, go ahead. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This captures https://gist.github.com/benbovy/adcb7d3b14d22014444a2c57efb30696/4e1456fe66092283491ade2e30a1a75f91592c33 and adds a package structure and tests.