Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dask #286

Merged
merged 7 commits into from
Mar 30, 2021
Merged

Unpin dask #286

merged 7 commits into from
Mar 30, 2021

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Mar 21, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #280

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance (if you touched existing code run asv to detect performance changes)
  • refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. This could point to a cell in the updated notebooks. Or a snippet of code with accompanying figures here.

Checklist (while developing)

  • I have added docstrings to all new functions.
  • I have commented my code, particularly in hard-to-understand areas
  • Tests added for pytest, if necessary.

Pre-Merge Checklist (final steps)

  • I have rebased onto master or develop (wherever I am merging) and dealt with any conflicts.
  • I have squashed commits to a reasonable amount, and force-pushed the squashed commits.

References

Please add any references to manuscripts, textbooks, etc.

@aaronspring aaronspring changed the title Update requirements.txt Unpin dask Mar 21, 2021
requirements.txt Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 21, 2021

Codecov Report

Merging #286 (4b270f2) into master (cdf9977) will decrease coverage by 0.60%.
The diff coverage is 95.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   95.45%   94.85%   -0.61%     
==========================================
  Files          20       24       +4     
  Lines        1914     2681     +767     
==========================================
+ Hits         1827     2543     +716     
- Misses         87      138      +51     
Impacted Files Coverage Δ
xskillscore/core/deterministic.py 97.54% <ø> (-2.46%) ⬇️
xskillscore/core/comparative.py 93.42% <88.23%> (-6.58%) ⬇️
xskillscore/tests/test_resampling.py 89.53% <89.53%> (ø)
xskillscore/core/utils.py 92.00% <90.24%> (+0.19%) ⬆️
xskillscore/core/probabilistic.py 91.79% <91.35%> (-1.19%) ⬇️
xskillscore/tests/test_probabilistic.py 96.50% <95.43%> (-3.50%) ⬇️
xskillscore/tests/conftest.py 98.70% <97.87%> (-1.30%) ⬇️
xskillscore/core/np_deterministic.py 99.17% <98.33%> (-0.36%) ⬇️
xskillscore/__init__.py 83.33% <100.00%> (ø)
xskillscore/core/accessor.py 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6e5e1...4b270f2. Read the comment docs.

@raybellwaves
Copy link
Member

@aaronspring aaronspring marked this pull request as ready for review March 29, 2021 21:22
requirements.txt Outdated Show resolved Hide resolved
@raybellwaves
Copy link
Member

raybellwaves commented Mar 30, 2021

Think it needs to be >= 2021.3.1. 2021.3 caused issues in xhistogram (xgcm/xhistogram#27). Could hang fire here until xhistogram puts out a new release (xgcm/xhistogram#40) or make that a separate PR.

@aaronspring
Copy link
Collaborator Author

!= means every version but that one. Worked before that version and will work after 2021.3.0. Please commit your preferred solution to this PR.

@raybellwaves raybellwaves merged commit c8a5233 into master Mar 30, 2021
@raybellwaves
Copy link
Member

Thanks @aaronspring

@raybellwaves raybellwaves deleted the AS_unpin_dask branch April 25, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unpin dask
3 participants