-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make XataApiClient to use ES Proxies #1287
Conversation
Signed-off-by: Alexis Rico <sferadev@gmail.com>
🦋 Changeset detectedLatest commit: f6c7a51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Your pull request has been published to npm. You can install @xata.io/client by running:
Other packages are published like this:
To test the CLI, run:
[Pull request has been updated, please wait for latest changes to be pushed to npm...] |
size-limit report 📦
|
This reverts commit ca1153f. Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Co-authored-by: Alexis Rico <sferadev@gmail.com>
test/integration/smoke.test.ts
Outdated
@@ -88,7 +88,7 @@ describe('API Client Integration Tests', () => { | |||
tableName: 'table' | |||
}, | |||
body: { | |||
record: { email: 'example@foo.bar' } | |||
email: 'example@foo.bar' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have had a bug here and didn't notice. I don't think this part of the API was/should be changed. The input here is not typesafe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added this test on Friday, weird I didn't catch it
5ae5ecc
to
4c4a56d
Compare
413b115
to
30bf0ec
Compare
No description provided.