-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backfill benchmarks #412
Conversation
@andrew-farries I think is is fine for now. What I'd like to do is add the other benchmarks in separate PR's and then once we have them all work on the job of persisting to S3. For now, we can always check out branches locally and run the benchmarks to spot check performance improvements. |
Also, as we add more benchmarks some pattern will probably emerge which will help pull out some duplicated code. |
I've just added tests for write amplification too. It does appear to be a bottleneck where having the triggers in place limits updates to around 15k row/s second on my machine compared with about 60k without the trigger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with a couple of questions.
This should still be enough for now and we can increase later if we need to.
I'll merge now to get some baseline runs in CI and then add some checks that fail the run in CI if it's slower than 30% of the current baseline. |
This change adds a benchmark that run against 10k, 100k and 1 million rows.
They benchmark:
This should give us a baseline metric that we can use to compare performance over time.
Example output:
Part of #408