-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Column field from DropConstraint #431
Conversation
By passing it in we are now able to lookup the column for a constraint when dropping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here are fine.
JSON validation rejects unknown fields so existing drop_constraint
operations that include the column
field will no longer be valid.
This will require existing migrations to be edited otherwise they won't apply.
Do you mean existing migrations that exist within xata? |
Yes, any existing branches that have a drop constraint migration in their history will fail to have their migations replayed when a user creates a new branch. |
We can look this up from the schema so can remove it from the spec.
This is a breaking change since we remove a field from the schema.
Part of #105