Change SQL fomatting tool to pgformatter
#477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
force-pushed
the
change-sql-formatter
branch
2 times, most recently
from
bacb3c6 to
aa523cd
Compare
|
Agree, it's more about consistency |
andrew-farries
force-pushed
the
change-sql-formatter
branch
from
aa523cd to
0e49bb3
Compare
Base automatically changed from
fix-read-schema-for-multi-column-fks
to
main
November 21, 2024 09:50
andrew-farries
force-pushed
the
change-sql-formatter
branch
from
0e49bb3 to
3ac3014
Compare
ryanslade
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the SQL formatting tool used by
make formatfrom sql-formatter to pgFormatter.Stop using
sql-formatterbecause it doesn't work on theread_schemafunction:doesn't change the file regardless of whatever changes are made to
read_schema.pgFormatterproduces consistent formatting on theread_schemafunction so let's use that.I'm not convinced that either formatting tool gave us formatting that was better than what we were doing by hand before. It's a question of consistency vs personal preference.