Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of Column.Nullable from *bool to bool #496

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

andrew-farries
Copy link
Collaborator

Change the type generated by the JSON schema for the Column.Nullable field from *bool to bool.

This simplifies use of the field when using pgroll from code.

@andrew-farries andrew-farries force-pushed the no-pointer-type-for-nullable branch from cc4539d to 5aa59b2 Compare November 27, 2024 08:39
@andrew-farries andrew-farries marked this pull request as ready for review November 27, 2024 08:43
Base automatically changed from no-pointer-type-for-pk to main November 27, 2024 09:34
Set a default value so that the generated type is `bool` rather than
`*bool`.
@andrew-farries andrew-farries force-pushed the no-pointer-type-for-nullable branch from 5aa59b2 to ba31b25 Compare November 27, 2024 09:37
@andrew-farries andrew-farries merged commit e02c4a2 into main Nov 27, 2024
27 checks passed
@andrew-farries andrew-farries deleted the no-pointer-type-for-nullable branch November 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants