Convert ALTER TABLE foo ADD CONSTRAINT bar UNIQUE (a) SQL to pgroll operation
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert SQL DDL of the form:
```sql
"ALTER TABLE foo ADD CONSTRAINT bar UNIQUE (a)"
```
To the equivalent `pgroll` operation:
```json
[
{
"create_constraint": {
"type": "unique",
"table": "foo",
"name": "bar",
"columns": ["a"],
"up": {
"a": "...",
},
"down": {
"a": "..."
}
}
}
]
```
We need to be conservative when converting SQL statements to `pgroll` operations to ensure that information present in the SQL is not lost during the conversion. There are several options possible as part of `ADD CONSTRAINT ... UNIQUE` statements that aren't representable by the `OpCreateConstraint` operation; in these cases we must resort to converting to an `OpRawSQL`.
exekias
approved these changes
Dec 4, 2024
andrew-farries
deleted the
sql2pgroll-alter-column-add-unique-constraint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert SQL DDL of the form:
"ALTER TABLE foo ADD CONSTRAINT bar UNIQUE (a)"To the equivalent
pgrolloperation:[ { "create_constraint": { "type": "unique", "table": "foo", "name": "bar", "columns": ["a"], "up": { "a": "...", }, "down": { "a": "..." } } } ]We need to be conservative when converting SQL statements to
pgrolloperations to ensure that information present in the SQL is not lost during the conversion.There are several options possible as part of
ADD CONSTRAINT ... UNIQUEstatements that aren't currently representable by theOpCreateConstraintoperation, for example:In these cases we must resort to converting to an
OpRawSQL.Tests are added to cover these unrepresentable cases.
Part of #504