Change CREATE TABLE DEFAULT constraint handling
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
changed the base branch from
main
to
fix-initially-immediate-constraints
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
2 times, most recently
from
bd13dde to
6637821
Compare
ryanslade
approved these changes
Jan 2, 2025
andrew-farries
force-pushed
the
fix-initially-immediate-constraints
branch
from
5b04017 to
ec79280
Compare
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
from
6637821 to
19aff38
Compare
andrew-farries
force-pushed
the
fix-initially-immediate-constraints
branch
from
ec79280 to
c7eaa68
Compare
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
from
19aff38 to
cef3018
Compare
andrew-farries
force-pushed
the
fix-initially-immediate-constraints
branch
from
c7eaa68 to
1957ed9
Compare
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
from
cef3018 to
f03b847
Compare
When a column has a default value of `NULL`, the `default` field in the resulting `Column` object should be omitted, rather than set to `"NULL"`. This makes conversion of `CREATE TABLE` statements consistent with conversion of `ALTER TABLE ADD COLUMN` statements.
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
from
f03b847 to
48ea17e
Compare
andrew-farries
deleted the
change-create-table-default-constraint-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how
CREATE TABLEstatements like:are converted to
OpCreateTableoperations.When a column has a default value of
NULL, thedefaultfield in the resultingColumnobject should be omitted, rather than set to"NULL".This makes conversion of
CREATE TABLEstatements consistent with conversion ofALTER TABLE ADD COLUMNstatements.