Reduce duplication between CREATE TABLE and ADD COLUMN SQL conversion
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanslade
approved these changes
Jan 2, 2025
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
from
6637821 to
19aff38
Compare
andrew-farries
force-pushed
the
reduce-duplication-create-table-add-column
branch
from
2b40b5b to
243f01a
Compare
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
from
19aff38 to
cef3018
Compare
andrew-farries
force-pushed
the
reduce-duplication-create-table-add-column
branch
from
243f01a to
8e57056
Compare
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
from
cef3018 to
f03b847
Compare
andrew-farries
force-pushed
the
reduce-duplication-create-table-add-column
branch
from
8e57056 to
a6df553
Compare
andrew-farries
force-pushed
the
change-create-table-default-constraint-handling
branch
from
f03b847 to
48ea17e
Compare
andrew-farries
force-pushed
the
reduce-duplication-create-table-add-column
branch
from
a6df553 to
b6a5ce1
Compare
Base automatically changed from
change-create-table-default-constraint-handling
to
main
January 2, 2025 09:31
There is a lot of duplication between the `CREATE TABLE` and `ALTER TABLE ADD COLUMN` conversion code. Reduce the duplication by having the ALTER TABLE ADD COLUMN conversion code and the CREATE TABLE conversion code use the same `convertColumnDef` function, which handles the conversion of a column definition to a `migrations.Column` struct along with the conversion of the column constraints.
andrew-farries
force-pushed
the
reduce-duplication-create-table-add-column
branch
from
b6a5ce1 to
64c12ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of duplication between the
CREATE TABLEandALTER TABLE ADD COLUMNconversion code.Reduce the duplication by having the
ALTER TABLE ADD COLUMNconversion code and theCREATE TABLEconversion code use the sameconvertColumnDeffunction, which handles the conversion of a column definition to amigrations.Columnstruct along with the conversion of the column constraints.