Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push with clean fails as it tries to delete the HEROKU administered variables #32

Closed
ruchikasb opened this issue Jun 16, 2023 · 12 comments · Fixed by #33
Closed

push with clean fails as it tries to delete the HEROKU administered variables #32

ruchikasb opened this issue Jun 16, 2023 · 12 comments · Fixed by #33

Comments

@ruchikasb
Copy link

No description provided.

@ruchikasb ruchikasb changed the title DB config vars not in env file; heroku push with clean fails as it tries to delete the HEROKU administered variables DB config vars not in my local env file; heroku push with clean fails as it tries to delete the HEROKU administered variables Jun 16, 2023
@xavdid
Copy link
Owner

xavdid commented Jun 16, 2023

Can you give examples of the heroku variables it's failing to delete?

@xavdid xavdid changed the title DB config vars not in my local env file; heroku push with clean fails as it tries to delete the HEROKU administered variables push with clean fails as it tries to delete the HEROKU administered variables Jun 16, 2023
@ruchikasb
Copy link
Author

ruchikasb commented Jun 16, 2023 via email

@xavdid
Copy link
Owner

xavdid commented Jun 16, 2023

Got it. Does it give a specific error saying you can't delete DATABASE_URL?

@ruchikasb
Copy link
Author

"Cannot overwrite attachment values DATABASE_URL"

@xavdid
Copy link
Owner

xavdid commented Jun 16, 2023

Ok, I have what should be a fix up. I wasn't able to test it myself, so do you mind doing that?

Instructions:

  1. git clone git@github.com:xavdid/heroku-config.git
  2. git checkout no-write-heroku-urls
  3. heroku plugins:link .

Then, when you run heroku plugins, it should mention (link)

You'll be able to use the config commands like normal. If you feel confident with the change, let me know and I'll merge and release.

@ruchikasb
Copy link
Author

will test and let you know

@ruchikasb
Copy link
Author

Update to DATABASE_URL
Also, for shared database, Heroku generates a random Variable like HEROKU_POSTGRESQL_RED, general format is HEROKU__

@ruchikasb
Copy link
Author

It still behaves the same.
Plugin link is there
heroku-builds 0.0.29
heroku-config 1.6.2 (link) /home/jenkins/heroku-config
heroku-repo 1.0.14
heroku-slugs 1.1.0

But when doing clean
I still get
No updated values to write; skipping
18:09:59 ▸ Cannot overwrite attachment values DATABASE_URL,
18:09:59 ▸ HEROKU_POSTGRESQL_MAUVE_URL.

@xavdid
Copy link
Owner

xavdid commented Jul 19, 2023

Apologies, I had a missing pair of parens in my logic. I've updated it in 9bbbee0.

Could you git pull in your clone and try again?

@ruchikasb
Copy link
Author

This change is working. Verified.

@xavdid
Copy link
Owner

xavdid commented Aug 11, 2023

This is released in 1.6.3.

Thank you!

@ruchikasb
Copy link
Author

ruchikasb commented Aug 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants