Features/hdev 1991 new asset #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiashu
requested changes
May 8, 2024
| function configureAssets(DistributionTypes.AssetConfigInput[] calldata assetsConfigInput) external override { | ||
| require(msg.sender == EMISSION_MANAGER, 'ONLY_EMISSION_MANAGER'); | ||
|
|
||
| for (uint256 i = 0; i < assetsConfigInput.length; i++) { |
There was a problem hiding this comment.
cache assetsConfigInput.length in a local var, should save some gas
| function _claimRewards(address user, DistributionTypes.UserStakeInput[] memory stakes) internal returns (uint256) { | ||
| uint256 accruedRewards = 0; | ||
|
|
||
| for (uint256 i = 0; i < stakes.length; i++) { |
There was a problem hiding this comment.
same, cache stakes.length to save some gas
| ) internal view returns (uint256) { | ||
| uint256 accruedRewards = 0; | ||
|
|
||
| for (uint256 i = 0; i < stakes.length; i++) { |
There was a problem hiding this comment.
cache stakes.length to save some gas
| uint256 reserveIndex, | ||
| uint256 userIndex | ||
| ) internal pure returns (uint256) { | ||
| return principalUserBalance.mul(reserveIndex.sub(userIndex)).div(10 ** uint256(PRECISION)); |
There was a problem hiding this comment.
because PRECISION is in 18 decimals, this line of code assumes principalUserBalance and reserveIndex and userIndex are also in 18 decimals. Is that ALWAYS going to be the case?
| uint256 timeDelta = currentTimestamp.sub(lastUpdateTimestamp); | ||
| //console.log("timeDelta: ", timeDelta); | ||
| //console.log("emissionPerSecond: ", emissionPerSecond); | ||
| return emissionPerSecond.mul(timeDelta).mul(10 ** uint256(PRECISION)).div(totalBalance).add(currentIndex); |
There was a problem hiding this comment.
emissionPerSecond * timeDelta * 1e18 / totalBalance + currentIndex
I don't understand why currentIndex is being added here.
| address constant aTokenAddress = address(0); // @todo change | ||
| address constant sdtAddress = address(0); // @todo change | ||
| address constant vdtAddress = address(0); // @todo change | ||
| address constant aTokenImplAddress = address(0); // @todo change |
There was a problem hiding this comment.
will transform this to a config!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Link to Jira Ticket
How To Test
Developer Checklist:
feature/HDEV-XXX-descriptionReviewers Checklist: