This repository has been archived by the owner on May 9, 2022. It is now read-only.
Fix web assets path #118
Merged
Fix web assets path #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not work for the wasm artifacts :( As a quick solution we could move the |
Robert-Steiner
force-pushed
the
fix-web-assets-path
branch
from
cbb0dd9
to
2a5c220
Compare
acrrd
approved these changes
Jun 29, 2021
Robert-Steiner
force-pushed
the
fix-web-assets-path
branch
from
2a5c220
to
694cf3a
Compare
|
I just rebased and rechecked each target. Looks good🚀 |
acrrd
pushed a commit
that referenced
this pull request
Aug 24, 2021
* move wasm bindings into assets folder
acrrd
pushed a commit
that referenced
this pull request
Nov 4, 2021
* move wasm bindings into assets folder
|
@Robert-Steiner do you know when this fix will be in the stable branch? I'm on the current stable and have the same problems with my images. It's good that we can manually adjust the build output to work around the issue. |
It's better if you ask on some flutter issue related to this problem. |
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter build webandflutter run -d chromebehave differently when bundling the web assets. Influtter run -d chromewe can access an asset viahttp://localhost:56864/assets/assets/qambert_v0001/qambert.onnxorhttp://localhost:56864/assets/qambert_v0001/qambert.onnx. Withflutter build web, on the other hand, we can only access an asset viahttp://localhost:56864/assets/assets/qambert_v0001/qambert.onnx.There are several tickets that relate to this problem:
In this PR we change the
_baseAssetUrlfrom/assetsto/assets/assetsso that it works for both commands.