Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

TY-1686 Analytics #54

Merged
merged 11 commits into from
Apr 27, 2021
Merged

TY-1686 Analytics #54

merged 11 commits into from
Apr 27, 2021

Commits on Apr 26, 2021

  1. TY-1686: Implemented nDCG@k analytics for all accessible stats.

    Currently this is not implemented for initial ranking as it
    is currently not accessible. (Defaults to NaN.)
    
    Some parts are currently implemented in a performance wise
    suboptimal way.
    rustonaut committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    f4de3b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a535aaf View commit details
    Browse the repository at this point in the history
  3. TY-1686: Cleaned up comments and code.

    Tests now use the test_ prefix and are not in
    sub-modules.
    rustonaut committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    cc8fe17 View commit details
    Browse the repository at this point in the history
  4. TY-1686: Fix clippy hints.

    rustonaut committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    0f2ced9 View commit details
    Browse the repository at this point in the history
  5. Added more tests.

    This includes a test of the `compute_analytics` methods,
    and a port of the test from the prev. dart implementation
    (as far as applicable).
    rustonaut committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    b66c347 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    575b35b View commit details
    Browse the repository at this point in the history
  7. Applied changes discussed in the review

    - skip if no history available for a document
    - if we have no relevant historic information at all
      we do return an error
    - use fold in dcg
    - in pick highest skip search if we won't be able to insert
      it anyway
    - use Iterator::fuse() instead of FusedIterator
    rustonaut committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    f2c9c7b View commit details
    Browse the repository at this point in the history
  8. Unified f32_total_cmp and nan_safe_sort_desc_comparsion.

    The new function is called nan_safe_f32_cmp.
    rustonaut committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    be645da View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Configuration menu
    Copy the full SHA
    ccff90d View commit details
    Browse the repository at this point in the history
  2. Added approx_f32_eq which uses float_comp::approx_eq.

    assert!(approx_eq!(f32, left, right, ulps=n)) has the
    problem that it doesn't print information about the
    values when it fails so assert_f32_eq adds a format
    string which on failure will be used as error message.
    rustonaut committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    92315e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b246d56 View commit details
    Browse the repository at this point in the history