This repository has been archived by the owner on May 9, 2022. It is now read-only.
Downgrade rust to 1.51 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might contain a "workaround" rust-lang/rust#79408 |
There was a problem hiding this comment.
i guess we also have to revert the linter changes of #69? even if the compiler ignores unknown lints, the old lints won't be checked by the ci. or do we just downgrade the rust version today until the release is done and upgrade it immediatly afterwards?
Co-authored-by: janpetschexain <58227040+janpetschexain@users.noreply.github.com>
|
I don't plan to revert this right after but only when we have a proper way to use 1.52. I reverted the lints because they are unstable for 1.51. |
janpetschexain
approved these changes
May 17, 2021
Co-authored-by: Robert Steiner <robertt.debug@gmail.com>
Co-authored-by: Robert Steiner <robertt.debug@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the app for ios fail with 1.52:
https://github.com/xaynetwork/xayn_search/runs/2572432935?check_suite_focus=true#step:10:1167
The problem seems to be that 1.52 uses llvm 12 and that is incompatible with xcode.
We are reverting to 1.51 but we disable incremental compilation as done in 1.52.1 to avoid compilation issue.