This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Improve the docker infra #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image we currently produce is over 4GB large. In order to reduce this, we perform the compilation in a build container, and just copy the coordinator and aggregator binaries to the final image. This commit also removes the dependency vendoring. The main reason for having it was to cache the dependencies. But that doesn't cache the builds. Instead we use `cargo fetch` and `cargo build` on an empty project that contains all our dependencies to force cargo to cache them. Finally, we split the images: - an image to upload to docker hub, that contains a release build - an image for development that contains a debug build as well as some dev tools (Valgrind)
dkravetz
reviewed
Mar 26, 2020
dkravetz
approved these changes
Mar 26, 2020
Robert-Steiner
approved these changes
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image we currently produce is over 4GB large. In order to reduce
this, we perform the compilation in a build container, and just copy
the coordinator and aggregator binaries to the final image.
This commit also removes the dependency vendoring. The main reason for
having it was to cache the dependencies. But that doesn't cache the
builds. Instead we use
cargo fetchandcargo buildon an emptyproject that contains all our dependencies to force cargo to cache
them.
Finally, we split the images:
dev tools (Valgrind)