Map refac #123

lukarenko · 2024-04-29T13:12:45Z

Description

Map type and overlay was moved to leafletHelpers.js and is now reused in all maps
OpenSeaMap overlay off by default on all maps
Timelapse: All query parameters are with underscores.
map_type query parameter now expects string (but still works with numerical 0 and 1 for old URLs), fallback to Satelitte
ignore_moorage_overlay changed to moorage_overlay to avoid double negation
fixed parsing boolean values from query parameters
all component props renamed to camelCase

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Switch to helper class for following maps: - logbook - moorages - default map (dashboard)

- map_type now using string ID - keep backward compatibility for 0 and 1 numericals -

This should be selected by user

- Ignore Moorage Overlay -> Show Moorage Overlay - map_type is now sent as string

xbgmsharp · 2024-04-30T12:02:05Z

thanks Awesome work

lukarenko added 10 commits April 29, 2024 11:49

Move all maps config to helper class

5c13aa4

Switch to helper class for following maps: - logbook - moorages - default map (dashboard)

Moorages: fallback map should be default

c6daaad

cleanup: not used

eaa716e

EMODnet

447c3bb

Timelapse: use helper class

4995b8d

- map_type now using string ID - keep backward compatibility for 0 and 1 numericals -

OpenSeaMap off by default

72b7e9c

This should be selected by user

Map component: switch to standard camelCase for parameters

d6cef38

This should be selected by user

Timelapse - Tune: refac

ab029b9

- Ignore Moorage Overlay -> Show Moorage Overlay - map_type is now sent as string

Fix parsing boolean value

a698d6b

Timelapse: fallback to Satelitte if map type not found.

c317874

lukarenko requested a review from xbgmsharp April 29, 2024 13:12

lukarenko added 6 commits April 29, 2024 15:29

map-zoom instead of zoom props

f3fd2aa

fix map-zoom

c1b7ba9

zoom -> mapZoom fix

0263d38

Fallback map should be simplified (CARTO)

f0fdc02

Fix new logbook details map

8d5f5da

Merge branch 'live' into map-refac

940d266

xbgmsharp merged commit e410766 into live Apr 30, 2024
3 checks passed

xbgmsharp deleted the map-refac branch April 30, 2024 12:02