Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup code: remove obsolete files, lMap component also also for log-map #134

Merged
merged 38 commits into from
May 20, 2024
Merged

Cleanup code: remove obsolete files, lMap component also also for log-map #134

merged 38 commits into from
May 20, 2024

Conversation

lukarenko
Copy link
Collaborator

@lukarenko lukarenko commented May 14, 2024 •
edited
Loading

Description

New features:

  • lMap: add sidepanel support

    • id: specify id for lMap (can be used for css settings in <style>)
    • tabs: specify tab IDs in sidepanel, actual tab name/icon and content in slots
    • tabs-auto-open: open sidepanel when loaded
    • externalLink: provide URL for external link button (optional)

  • Monitoring: full screen with sidebar

    • make map full screen
    • just moved LCD displays to sidepanel
image
  • Logbook-Map: switch to common lMap with sidepanel
    • improved caching/refresh for Save note and Delete point
    • simplified refresh of logbook name on geojson LineString

Cleanups:

  • timelapse: remove obsolete Timelapse.vue, Timelapse2.vue
  • logbook: remove obsolete Details.vue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

lukarenko added 30 commits May 14, 2024 11:09
@lukarenko
Remove obsolete Timelapse.vue/Timelapse2.vue
9483e13
@lukarenko
Remove logs-book/Details.vue
4ca4a07 
replaced by DetailsMap.vue
@lukarenko
lMap: add sidepanel support, prepare for integration
36cd307
@lukarenko
Sidepanel proto on Monitoring - WIP
a939539 
Need to put actual content in
@lukarenko
MoorageMap also uses full page
817670c
@lukarenko
sidepanel dark mode
9c621a4
@lukarenko
Fix sidepanel over navbar
daa3a7c
@lukarenko
Monitoring: full-screen fix
971759b
@lukarenko
Move sidepanel to Monotoring
3a5369a 
this will simplify integration
@lukarenko
Monitoring sub panel works, no real content yet
1b2f50b
@lukarenko
Monitoring: move lcd-displays to sidepanel
2167dc8
@lukarenko
Merge branch 'live' into cleanup
42bdc9d
@lukarenko
logbook-map now using lMap
822086d 
lMap new features:
- boatType selector
- externalLink

Not implemented yet:
- note in popup
- save note in popup
- delete point in popup

Needs extensive testing
@lukarenko
Monitoring: battery to last
a5183ee
@lukarenko
logbook-map: show note, save/delete buttons
dea3adf 
save/delete still not working
@lukarenko
Another try on save/delete
2a9097d
@lukarenko
Cleanup
e572b7a
@lukarenko
Removed commented code
ff39ece
@lukarenko
Revert "Another try on save/delete"
f8cffb7 
This reverts commit 2a9097d.
@lukarenko
Fix logs map (do not show boat type if multijson)
051a463
@lukarenko
Add tabs-auto-open props to control auto open
bdc93c8
@lukarenko
save-note and delete-point events working
661b04b 
emit from lMap to page works, need to move the code around and switch to v-model
@lukarenko
Monitoring: auto-open panel
1557985
@lukarenko
lMap: switch to v-model for geo-json-features
e12c777 
This allows mapGeoJsonFeatures to be shared and changed by lMap and page with lMap.
Will allow implementation of saveNote and deletePoint. Still not working, need to debug more.
@lukarenko
Fix for coords passing
6f445a0
@lukarenko
Cleanup
ef18b44
@lukarenko
Clear cache after DeletePoint too
1e12ae9
@lukarenko
Cleanup GeoJSONbasemapObj
92cfd4a 
now in lMap
@lukarenko
Refac: name v-model geoJsonFeatures
822fbc3
@lukarenko
Refac: popup text functions for point and line
b3ae6aa
@lukarenko lukarenko changed the title Cleanup codebase Cleanup code: remove obsolete files, lMap component also also for log-map May 16, 2024
@lukarenko lukarenko requested a review from xbgmsharp May 16, 2024 20:45
@xbgmsharp xbgmsharp merged commit bf33ecf into live May 20, 2024
3 checks passed
@xbgmsharp
Copy link
Owner

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xbgmsharp xbgmsharp Awaiting requested review from xbgmsharp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukarenko @xbgmsharp