Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dash] Support urn:scte:da sh:cc:cea-608:2015 (CEA-608 captions) #782

Open
matthuisman opened this issue Aug 30, 2021 · 10 comments
Open

[Dash] Support urn:scte:da sh:cc:cea-608:2015 (CEA-608 captions) #782

matthuisman opened this issue Aug 30, 2021 · 10 comments

Comments

@matthuisman
Copy link
Contributor

matthuisman commented Aug 30, 2021

shaka-project/shaka-player#1404
https://dashif.org/identifiers/subtitle_and_closed_captioning/

seems kodi does support them:
https://forum.kodi.tv/showthread.php?tid=359024
https://forum.kodi.tv/showthread.php?tid=330882

So maybe we just need to check for the value and set the name etc.

<AdaptationSet id="1" mimeType="video/mp4" segmentAlignment="true" bitstreamSwitching="true" maxWidth="1280" maxHeight="720" maxFrameRate="60000/1001">
	<Accessibility schemeIdUri="urn:scte:dash:cc:cea-608:2015" value="CC1=eng"/>
	<ContentProtection schemeIdUri="urn:mpeg:dash:mp4protection:2011" value="cenc" cenc:default_KID="664c5cf680145605888b30b76cd2e568"/>
	<ContentProtection schemeIdUri="urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95"/>
	<ContentProtection schemeIdUri="urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed"/>
	<SegmentTemplate timescale="90000" media="https://live-f.hulustream.com/VICE-MLB/VICE-MLB_146726828024220/$RepresentationID$/$Time$_video.m4s" initialization="https://live-f.hulustream.com/VICE-MLB/$RepresentationID$_10_video_init.mp4">
		<SegmentTimeline>
			<S t="2775830777" d="450450" r="21"/>
			<S d="495495"/>
		</SegmentTimeline>
	</SegmentTemplate>
	<Representation id="VICE-MLB_VIDEO_7_1200000" codecs="avc1.4d001f" width="640" height="360" startWithSAP="1" bandwidth="1322000" frameRate="30000/1001">
</Representation>
</AdaptationSet>

Hulu live channels seem to use these

@matthuisman matthuisman changed the title [Dash] Support urn:scte:dash:cc:cea-608:2015 (CEA-608 captions) [Dash] Support urn:scte:da_sh:cc:cea-608:2015 (CEA-608 captions) Aug 30, 2021
@matthuisman matthuisman changed the title [Dash] Support urn:scte:da_sh:cc:cea-608:2015 (CEA-608 captions) [Dash] Support urn:scte:da sh:cc:cea-608:2015 (CEA-608 captions) Aug 30, 2021
@CastagnaIT CastagnaIT added Component: MPEG-DASH Component: Subtitles Issue Type: New feature issue has requested a new feature Roadmap ticket on the Team roadmap labels Nov 28, 2021
@yeahme49
Copy link

Not sure if there is anything in the works yet for this, but would love to see it get added. Discovery+ USA uses CEA-608 captions as well so they are not working as of now.

@CastagnaIT
Copy link
Collaborator

i think has been finally found the problem of the start code that prevent load CC subtitles
at least from my test now works
please let a feedback after xbmc/xbmc#21410 PR will be merged

@matthuisman
Copy link
Contributor Author

Oh wow. That's great. I'll test once it's merged

@matthuisman
Copy link
Contributor Author

matthuisman commented May 17, 2022

Now merged. Should be in next nightly
KodiSetup-20220517

Also see Matrix backport done. That should also be in next 19 nightly

@enen92
Copy link
Member

enen92 commented May 20, 2022

@matthuisman fix confirmed?

@matthuisman
Copy link
Contributor Author

matthuisman commented May 20, 2022 via email

@CastagnaIT
Copy link
Collaborator

can you maybe try ask to some user in kodi forum?

@matthuisman
Copy link
Contributor Author

matthuisman commented May 21, 2022

ok, managed to get a login to test with

KodiSetup-20220520-43b96fc2-master-x64.exe
ISA 20.2.1

Not working unfortunately. No subs at all.
Files attached that hopefully will help

kodi.log.txt
manifest.mpd.txt
VIDEO_2_8800000_3_86a1050eef074667a44a2220678642a5_cenc_video_init.mp4.txt
148781520527640_cenc_video.m4s.txt

@CastagnaIT CastagnaIT removed Issue Type: New feature issue has requested a new feature Roadmap ticket on the Team roadmap labels May 21, 2022
@CastagnaIT
Copy link
Collaborator

video file is encrypted we should find a unencrypted sample to try debug cc demuxer in kodi core

@enen92
Copy link
Member

enen92 commented Jan 11, 2023

I am still interested in samples or accessing streams (temporarily) which cannot be displayed in Kodi (for xbmc/xbmc#22333)

So far the only public samples that didn't work are those provided by the dash industry forum (e.g: https://livesim.dashif.org/dash/vod/testpic_2s/cea608.mpd) but they are completely broken, see:

Dash-Industry-Forum/dash-live-source-simulator#99 (comment)
Dash-Industry-Forum/dash-live-source-simulator#115

Maybe we can give them a go later on if those major issues are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants