Cleanups / Improvements to PSSH, KID, init data #1668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganized code about PSSH parsing/generation to separate files
changed a bit
InitializeDRM
basically the same just changed order of variables, and following changes:ContentProtection
pro
is provided withoutcenc:pssh
to make tests for example the
DRM::FixPrHeader
method can be added toDRM::PSSH::Make
by checking thatsystemId
is playready, part of this solution come from exoplayer https://github.com/google/ExoPlayer/blob/dd430f7053a1a3958deea3ead6a0565150c06bfc/library/core/src/main/java/com/google/android/exoplayer2/drm/FrameworkMediaDrm.java#L491-L496. In my tests i see changes on android logcat but dont work yet.Motivation and context
another step to future drm rework
How has this been tested?
Screenshots (if appropriate):
Types of change
Checklist: