Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Base64Utils] Removed regex to validate base64 #1682

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

CastagnaIT
Copy link
Collaborator

Description

with very large strings regex can cause this error:

regex_error(error_stack): There was insufficient memory to determine whether the regular expression could match the specified character sequence

seem to be a common c++ regex library problem that happen when a pattern is complex, so has been replaced with similar code implementation

Motivation and context

fix #1681

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v22 Piers labels Oct 3, 2024
with very large strings regex can cause this error:
regex_error(error_stack): There was insufficient memory to determine whether the regular expression could match the specified character sequence

seem to be a common c++ library problem that happen when regex pattern
is complex, so has been replaced with similar code implementation
@CastagnaIT CastagnaIT marked this pull request as ready for review October 3, 2024 15:04
@CastagnaIT CastagnaIT merged commit 4794c89 into xbmc:Piers Oct 4, 2024
10 checks passed
@CastagnaIT CastagnaIT deleted the fix_regex branch October 4, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] New inputstream.adaptive.drm property - problem with reading/parsing req_data
1 participant