-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skin.copacetic] 1.1.27 #435
Conversation
- removal of execute permissions
Hi @ronie @Hitcher - after I removed those two files, the addon checker ran last night. It failed again, but this time I could see it was because the execute permissions were incorrectly set on all my files (because I had created them on Windows originally). So I fixed that and decided to make a clean PR - but it's failing again with the original complaint about incorrect format for 'skin.copacetic' before the addon checker is even run, which is confusing because last night it did run after those two files with the unsupported characters were removed. |
i have no idea about the addon checker script, but this time it seems to be failing on these files: |
since everything looks ok to me, i'm going to merge this regardless of the addon checker error. |
Thanks @ronie what do you use to check? I'll go through all the flag memes to check for illegal characters before next time |
I guess ronie either uses Skin XML Converter + Formatter or SublimeText3 plugin. |
yup, i'm using the sublime plugin. as for the addon checker error, i noticed it was failing on this command:
so i ran that command (and a few variations of it) locally on your PR to figure out the issue. |
Thanks @ronie , I've not been able to get very far with SublimeText3 plugin unfortunately. I deleted those files, so hopefully next time it won't fail! The reason I had them with the accents was because they were here so I thought that meant it was ok: https://github.com/XBMC-Addons/resource.images.studios.white/blob/master/resources/B%C3%B3rd%20Scann%C3%A1n%20na%20h%C3%89ireann.png |
it could be that the addon-checker script just can't handle those filesnames, i'm not sure. as a recommendation from my end, you can also remove the studio flags from your skin |
Description
1.1.27
1.1.26
1.1.25
1.1.24
1.1.23
1.1.22
1.1.21
1.1.20
missing genre in media info realcopacetic/skin.copacetic#116
honor show media file path in media info realcopacetic/skin.copacetic#115
1.1.18-19
1.1.17
Checklist:
Additional information :