Rework OS screen saver handling #12342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
reviewed
Jun 24, 2017
|
|
||
| uint32_t sdlFlags = 0; | ||
|
|
||
| #if defined(TARGET_DARWIN_OSX) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
FernetMenta
reviewed
Jun 24, 2017
| CLog::LogF(LOGNOTICE, "Setup SDL"); | ||
|
|
||
| /* Clean up on exit, exit on window close and interrupt */ | ||
| std::atexit(SDL_Quit); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Rebased on #12353 so it builds on all platforms (hopefully) |
|
OSX built an older commit |
|
Build looks OK now - opinions? |
|
+1 |
|
please rebase on master to get rid of the commits from #12353 in this PR |
This isn't C
This changes the rules and functionality of the OS screen saver inhibition to be more in line in with how modern desktop environments work. Constant resetting of the screen saver is not necessary usually. If it is, the platform-specific backend will have to implement it. On desktop machines (that have an OS screen saver), the default should be to use that. If the user then chooses to activate the Kodi screen saver, this should completely override the OS screen saver as far as permitted by the desktop environment. During video playback etc., the OS screen saver must always be inhibited regardless of whether the Kodi screen saver is enabled. In embedded environments (that do not have an OS screen saver), the default should be to use the Kodi screen saver.
|
rebased |
|
jenkins build this please |
2 similar comments
|
jenkins build this please |
|
jenkins build this please |
MartijnKaijser
added
Type: Improvement
|
This change seems to be causing Kodi on my Ubuntu 16.04 system to kill the screen after a few minutes. This never happened before. I didn't change anything about my OS or Kodi settings other than upgrading to a newer nightly. |
|
What exactly do you mean it "kills" your screen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the WinSystemBase OS screen saver interface
Description
Current Kodi OS screen saver handling is not adapted to modern desktop windowing systems (which mostly use inhibitors instead of simulated activity) and it's unclear what it's trying to achieve. Some options might have been lost in time, especially on X11. New approach discussed with @FernetMenta:
screensaver.xbmc.builtin.dimotherwise (embedded systems)from yol#7 (comment)
Motivation and Context
I looked into screen saver handling for the Wayland windowing implementation and noticed while reading the OSX and X11 code that the current state is quite inconsistent.
How Has This Been Tested?
X11 backend tested with various setting combinations.
OSX is untested and really not my area of expertise, so any feedback would be much appreciated.
Screenshots (if appropriate):
Types of change
Checklist: