Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatabaseManager: convert DBStatus to enum class #26093

Merged
merged 1 commit into from
Dec 14, 2024
Merged

DatabaseManager: convert DBStatus to enum class #26093

merged 1 commit into from
Dec 14, 2024
+15 −9

Conversation

notspiff
Copy link
Contributor

Description

Convert an enum to enum class

Motivation and context

More modern, more type safe

How has this been tested?

It builds

What is the effect on users?

None

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@notspiff notspiff added Type: Improvement non-breaking change which improves existing functionality v22 Piers labels Dec 13, 2024
@notspiff notspiff added this to the Piers 22.0 Alpha 1 milestone Dec 13, 2024
garbear
garbear approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notspiff notspiff force-pushed the dbmanager_dbstatus_enum_class branch from 084a5b2 to dfd7159 Compare December 14, 2024 14:08
@notspiff notspiff merged commit a82dfb0 into xbmc:master Dec 14, 2024
2 checks passed
@notspiff notspiff deleted the dbmanager_dbstatus_enum_class branch December 14, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzard fuzzard fuzzard approved these changes

@garbear garbear garbear approved these changes

Assignees
No one assigned
Labels
Type: Improvement non-breaking change which improves existing functionality v22 Piers
Projects
None yet
Milestone
Piers 22.0 Alpha 1
Development

Successfully merging this pull request may close these issues.
3 participants
@notspiff @garbear @fuzzard