Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome/Edge Extension pop-up window does not adjust accordingly when zoom level is not 100% #173

Closed
ElTopo opened this issue Mar 31, 2020 · 4 comments
Labels

Comments

@ElTopo
Copy link

ElTopo commented Mar 31, 2020

Describe the issue you are experiencing
Chrome/Edge Extension's pop up window does not adjust accordingly with browser's zoom level other than 100%, user has to scroll right to see some icons (bookmark, settings)

How can the issue be reproduced?
Steps to reproduce the behavior for Microsoft Edge (chromium):

  1. Go to menu "Settings" / "Appearance"
  2. Adjust "Zoom" level to 100% or 150%
  3. Click on XBrowserSync icon and check the extension's pop up window

Screenshots
When Zoom level is set to 100%:
Screenshot - 3_31_2020 , 11_39_48 AM

When Zoom level is set to 150%
Screenshot - 3_31_2020 , 11_36_30 AM

Desktop browser
Please complete the following information for all affected desktop browsers:

  • OS: Win10
  • Browser Microsoft Edge
  • Version 80.0.361.69 (Official build) (64-bit)
@nero120 nero120 added the bug label Apr 6, 2020
@nero120
Copy link
Member

nero120 commented Apr 7, 2020

@ElTopo after doing some testing on this issue, unfortunately there's nothing I can do to avoid scroll bars when you use browser zoom. There is no functionality I can use to properly detect or adjust layouts for browser zoom that will avoid scroll bars completely. Whilst I am making some changes to use more relative units when setting layout dimensions which will help in some cases, it won't resolve all sadly.

I will relate the changes to this issue once they are committed but I am now going to close it as above.

@nero120 nero120 closed this as completed Apr 7, 2020
@nero120 nero120 added wontfix and removed bug labels Apr 7, 2020
nero120 added a commit that referenced this issue Apr 8, 2020
Updated invalid creds error message localised string.
@nero120
Copy link
Member

nero120 commented Apr 9, 2020

v1.5.2 has now been released that includes a partial fix for this issue.

@ElTopo
Copy link
Author

ElTopo commented Apr 10, 2020

@nero120 I updated to v1.5.2 today and this issue seems fixed and I am satisfied, thanks.

@nero120
Copy link
Member

nero120 commented Apr 11, 2020

Great stuff @ElTopo, glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants