Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out connection code #36

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Split out connection code #36

merged 1 commit into from
Feb 22, 2022

Conversation

epenet
Copy link
Collaborator

@epenet epenet commented Feb 21, 2022

As preliminary work for a new SamsungTVWSAsyncConnection class

@epenet epenet force-pushed the ci branch 3 times, most recently from 84a5caf to e6045a4 Compare February 21, 2022 18:56
@epenet
Copy link
Collaborator Author

epenet commented Feb 22, 2022

Hi @xchwarze did you get a chance to look at this PR?
This makes the following chain: SamsungTVWS > SamsungTVWSConnection > SamsungTVWSBaseConnection
Which will then allow me to create SamsungTVWSAsyncConnection > SamsungTVWSBaseConnection

@epenet
Copy link
Collaborator Author

epenet commented Feb 22, 2022

Linked to: #31 and home-assistant/core#67042

@xchwarze xchwarze merged commit b23283b into xchwarze:master Feb 22, 2022
@xchwarze
Copy link
Owner

Sorry for the delay, I'm traveling and the internet doesn't work well

@epenet epenet deleted the ci branch February 22, 2022 20:01
@epenet
Copy link
Collaborator Author

epenet commented Feb 22, 2022

Thanks
I'll carry on this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants