Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event callback to async connection #53

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

epenet
Copy link
Collaborator

@epenet epenet commented Feb 28, 2022

This is a simplified version of #11, but I only implemented it in async

@epenet epenet force-pushed the start_listening branch 2 times, most recently from ed5cfb6 to b959034 Compare February 28, 2022 15:32
@xchwarze
Copy link
Owner

@epenet
would it be very difficult to implement it for the sync code?
I can't merge it because of the conflict

@xchwarze xchwarze merged commit 8756f55 into xchwarze:master Feb 28, 2022
@epenet
Copy link
Collaborator Author

epenet commented Feb 28, 2022

Thanks.

I had a look at the https://github.com/websocket-client/websocket-client documentation for the sync code, but I wasn't really confortable with the changes I was making to the sync code and I stripped it back out.

@epenet epenet deleted the start_listening branch February 28, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants