Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sequences and add hold_key support #66

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Enable sequences and add hold_key support #66

merged 1 commit into from
Mar 5, 2022

Conversation

epenet
Copy link
Collaborator

@epenet epenet commented Mar 4, 2022

This will enable POWER_OFF for FrameTV (= hold POWER for 3 seconds)

@epenet epenet marked this pull request as draft March 4, 2022 16:07
@epenet epenet force-pushed the hold-key branch 9 times, most recently from 8155766 to 9def975 Compare March 5, 2022 08:54
@epenet epenet changed the title Add hold_key to remote commands Enable sequences and add hold_key support Mar 5, 2022
@epenet epenet marked this pull request as ready for review March 5, 2022 08:58
@epenet
Copy link
Collaborator Author

epenet commented Mar 5, 2022

I struggled with python 3.7 compatibility in the tests, but now this is ready for merge

@xchwarze
Copy link
Owner

xchwarze commented Mar 5, 2022

thanks <3

@xchwarze xchwarze merged commit 88f5ec1 into xchwarze:master Mar 5, 2022
@epenet epenet deleted the hold-key branch March 5, 2022 21:17
@epenet
Copy link
Collaborator Author

epenet commented Mar 6, 2022 •
edited
Loading

Would you be able to bump the version please?
I would need this for my next HomeAssistant patch

@xchwarze
Copy link
Owner

xchwarze commented Mar 6, 2022

@epenet done!

@epenet
Copy link
Collaborator Author

epenet commented Mar 6, 2022

Thanks

@epenet epenet mentioned this pull request Mar 8, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epenet @xchwarze