Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with extra events in open routine #71

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

epenet
Copy link
Collaborator

@epenet epenet commented Mar 7, 2022

Spotted in Home Assistant: home-assistant/core#64465

@epenet
Copy link
Collaborator Author

epenet commented Mar 7, 2022

Will need to be rebased over #68 and #70

@epenet epenet force-pushed the fix-connect-issue branch from 6d7b2a0 to fcbbba6 Compare March 7, 2022 19:22
@epenet epenet marked this pull request as ready for review March 7, 2022 19:22
@xchwarze xchwarze merged commit 00b7b85 into xchwarze:master Mar 7, 2022
@epenet epenet deleted the fix-connect-issue branch March 7, 2022 19:25
@epenet
Copy link
Collaborator Author

epenet commented Mar 7, 2022

Thanks for merging.
I have a follow-up question about this one: in what context did you expect the ConnectionFailure to come up?

I was under the impression that it handled authentication failures, but in my own testing it didn't get raise on authentication failures at all (not when I pressed Deny, and not when I left it without pressing Allow or Deny)

Edit: let's not worry about the ConnectionFailure for the moment. We can always adjust later if there are more events being sent before the expected MS_CHANNEL_CONNECT_EVENT

@epenet
Copy link
Collaborator Author

epenet commented Mar 7, 2022

Also: since this is a fix, it would nice to have a release again when you get a chance...

@xchwarze
Copy link
Owner

xchwarze commented Mar 7, 2022

in what context did you expect the ConnectionFailure to come up?

mmmh I think when TV refuses to connect

@epenet
Copy link
Collaborator Author

epenet commented Mar 7, 2022

in what context did you expect the ConnectionFailure to come up?

mmmh I think when TV refuses to connect

In HA, it is used incorrectly to trigger re-authentication in the config flow. I'll have to fix that there after the dependency bump...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants