Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease user discovery of pw-hash & eula-auto-accept #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enidice
Copy link
Contributor

@enidice enidice commented Jun 23, 2022

Signed-off-by: Ewan Nisbet 93122210+enidice@users.noreply.github.com

I was close to creating a post in https://xcp-ng.org/forum/ before stumbling on xcp-ng/host-installer#18 (comment) - I suppose it is desirable to avoid posts where possible :)

Before submitting the pull request, you must agree with the following statements by checking both boxes with a 'x'.

  • "I accept that my contribution is placed under the CC BY-SA 2.0 license [1]."
  • "My contribution complies with the Developer Certificate of Origin [2]."

[1] https://creativecommons.org/licenses/by-sa/2.0/
[2] https://xcp-ng.org/docs/contributing.html#developer-certificate-of-origin-dco

Signed-off-by: enidice <93122210+enidice@users.noreply.github.com>
@stormi
Copy link
Member

stormi commented Jul 4, 2022

Actually, supplying a password should work whatever the type, from what I read in the code: https://github.com/xapi-project/xsconsole/blob/75a5162eb7fb2a97edc83ab6b2dd0a7abcfa274f/plugins-base/XSFeatureEULA.py#L95

@@ -359,6 +359,10 @@ Here's an example:
</installation>
```

:::tip
Supplying a password of type="hash" will suppress the EULA prompt on first boot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Supplying a password of type="hash" will suppress the EULA prompt on first boot.
If no password is supplied in the answerfile, users will be asked to accept the EULA and then set the password at first boot.

Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking with changes requested so that we don't merge early by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants