More tests for zfs-ng SMAPIv3 driver #214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
force-pushed
the
zfs-ng-more-tests
branch
2 times, most recently
from
25ea394
to
8b633df
Compare
stormi
reviewed
Mar 13, 2024
ydirson
force-pushed
the
zfs-ng-more-tests
branch
5 times, most recently
from
50acc91
to
b662d59
Compare
ydirson
force-pushed
the
zfs-ng-more-tests
branch
from
3d8b053
to
083151b
Compare
gthvn1
approved these changes
Mar 27, 2024
ydirson
force-pushed
the
zfs-ng-more-tests
branch
4 times, most recently
from
8999da4
to
44098f1
Compare
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
* this only tests clones of snapshots, as cloning without explicit snap is not supported yet FIXME: * vdi_and_snaps_chain is nothing specific to ZFS, should be moved to somewhere generic
… others Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
…by proto Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
No failure should happen, but this can be used to check in the logs that we only perform the single required "zfs promote" and not one per clone. FIXME: automate this check
Cloning a VDI without a snapshot is not implemented yet. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
... with side effect that some extra clones will now prevent destruction of some snapshots Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Cloning a VDI without a snapshot is just not implemented yet. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
ydirson
force-pushed
the
zfs-ng-more-tests
branch
from
44098f1
to
cd35610
Compare
…e fails TODO: all other SR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted tests:
Note: based on top of #202