-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for pxe #248
Open
gthvn1
wants to merge
75
commits into
ydi/install
Choose a base branch
from
gtn-pxe
base: ydi/install
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add support for pxe #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault-SR Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Other methods to get SRs return `SR` objects, this was inconsistent. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
"vm-cd-insert" does not mount anything, as the need for a subsequent "mount" in the only test using it shows. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
The entrypoint is ssh(), and the default values are already there. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Since f9b5365 the VM ctor takes care of reporting this info. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
This will be useful to the plugin that allows not rerunning a cached dependency: it needs to probe the cache. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
When testing in a nested setup, 2 min is not enough to boot a Debian 12 to the point the XS agent has published to xenstore. 5 min should be enough for everyone. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
…nning VM. There is no other inter-test dependency in this file, this allows to stop using @pytest.mark.incremental here. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Same as for test_basic_without_ssh, and this allows to stop using @pytest.mark.incremental here too. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Previous commits removed its two only uses, replaced by an autouse fixture. Other possible uses would be covered (with a more fine-grained approach) by pytest-dependency. This frees the global pytest_runtest_makereport hook for potential reuse. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
We will need this value in other places. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
And make the whole easier to copypaste. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Reported by mypy. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
We want to have it in log-file. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
With install tests the description becomes really long, use chars sparingly. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
The logger setup was confusing when using --log-file-level=DEBUG, showing this debug-level output inside default --log-cli-level=INFO output, but without the debug context that only went into the logfile, and without any hint of what kind of output it was. This makes it use the same logger as all other debug output, preventing it from appearing in the wrong place, and adds a marker to hint it is output data - at the same time fixing a potential formatting issue, where arbitrary ssh output lines were interpreted as *format strings*. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
FIXME: replace with explicit clone naming
If the host's name-label was changed using XO after installation, but the UNIX hostname was not, $HOSTNAME is wrong. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
We want to be able to change the resulting host UUID after install, and thus to produce different hosts based on a new parameter, but all of this only after initial install. FIXME: restore is even more different Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
The installer generates UUID for host and its dom0 in xensource-inventory, so the result of a costly install test could not be reused for multiple hosts in a same pool. This service will be run once and before xapi ever starts, to override those UUIDs with brand new random ones during firstboot.
beta2 did not have support for upgrading from 8.3, so more combos get activated. FIXME: test upgrade from beta2?
This is just base infra, different machines have not differences yet.
Uses a helper VM to modify firstboot data in installed disk
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
When the ISO is copied to the SR it happens that it is not available right now. So rescan the SR to ensure that it is available. Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech> FIXME: rescan after copying rather than on each use
clone+start:// will be used to implement--hosts=cache://... clone:// itself is not yet used directly, but as the "base" protocol upon which clone+start build, it seems logical (and basically free) to implement. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
FIXME: - installer_iso fixture could just use iso_version param ... except for gen_unique_uuid => turn into optional iso_remaster marker?
Add a new parameter to allow booting using netinstall. If an ISO only supports netinstall you can specify it in the data.py by setting the option `net-only` to True. This option is set to False by default. FIXME: - ISO_IMAGES should not require 'net-url' for every ISO Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech> Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
FIXME: shutdowns should instead be part of fixtures, so that --pdb allows to inspect them
Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
ydirson
force-pushed
the
ydi/install
branch
8 times, most recently
from
September 20, 2024 15:41
8854814
to
0860206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.