Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: don't use a separate logger #250

Merged
merged 3 commits into from
Sep 4, 2024
Merged

ssh: don't use a separate logger #250

merged 3 commits into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. ssh: don't use a separate logger

    The logger setup was confusing when using --log-file-level=DEBUG,
    showing this debug-level output inside default --log-cli-level=INFO output,
    but without the debug context that only went into the logfile, and without
    any hint of what kind of output it was.
    
    This makes it use the same logger as all other debug output, preventing it
    from appearing in the wrong place, and adds a marker to hint it is output
    data - at the same time fixing a potential formatting issue, where
    arbitrary ssh output lines were interpreted as *format strings*.
    
    Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
    ydirson committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c0cdb44 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Revert "Add the -s parameter back, necessary for SSH output in debug …

    …logs"
    
    This reverts commit 5b97ff0.
    
    With the unified logger the original issue is not there any more.
    
    Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
    ydirson committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2d9396b View commit details
    Browse the repository at this point in the history
  2. pytest: get DEBUG messages always generated

    They won't make it to the console unless required by --log-cli-level, but
    now pytest will show them systematically when a test fails.
    
    Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
    ydirson committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6c18d35 View commit details
    Browse the repository at this point in the history