-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated RPU test #253
Draft
ydirson
wants to merge
81
commits into
master
Choose a base branch
from
install-rpu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Automated RPU test #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
requested review from
gthvn1,
stormi,
tescande,
benjamreis and
gduperrey
September 5, 2024 16:41
ydirson
force-pushed
the
install-rpu
branch
10 times, most recently
from
September 10, 2024 11:33
610ca66
to
27a1d49
Compare
Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
ydirson
force-pushed
the
install-rpu
branch
from
September 10, 2024 15:12
27a1d49
to
f56c56d
Compare
In 0a5ea64 the method was moved from BaseVM to Pool, but an intermediate version had it moved to Host, and the final version missed the conversion on one call site, breaking tune_firstboot tests. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
This in INFO level makes user think the test is blocked on xapi-wait-init-complete while the problem is with reaching pool members: Sep 06 12:50:28.791 INFO Wait for XAPI init to be complete on 172.16.210.12 Sep 06 12:50:28.792 DEBUG [172.16.210.12] xapi-wait-init-complete 60 Sep 06 12:50:29.221 DEBUG [172.16.210.12] xe host-list --minimal ... Sep 06 12:50:30.503 DEBUG [172.16.210.12] xe host-param-get uuid=0aea61f4-c9d1-4060-94e8-4eb2024d082c param-name=address Sep 06 12:50:30.926 DEBUG > 172.16.210.11 Sep 06 12:50:30.929 DEBUG [172.16.210.11] cat /etc/xensource-inventory Sep 06 12:52:47.216 DEBUG > ssh: connect to host 172.16.210.11 port 22: Connection timed out Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
ydirson
force-pushed
the
install-rpu
branch
from
September 10, 2024 15:39
f56c56d
to
0cb96b8
Compare
Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Getting a vm_booted_with_installer starts with inserting a CD, will be progressively enhanced. ISOs are specified using a filename, or a download URL used through a local cache. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
This is a first step for answerfile handling, to be able to run a first real installation. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Currently relies on the installer fetching the answerfile from the PXE server, to ensure the latter's ARP tables are populated with the obtained DHCP address. Monitoring the install progress is done by repeatedly polling with grep, which is far from ideal performance-wise, but avoids adding too much complexity. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
Detection of host IP till now relies on the fact we download the answerfile from PXE server. Once we take this file from the ISO this network traffic won't happen so we need some other mechanism to fill the server's ARP tables. test-pingpxe.service is installed in install.img by iso-remaster. Since it is difficult to wait until the IP has been assigned before launching the service, make it ping continuously until we can reach the PXE server. One the installed host we will set a static IP instead. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
This is necessary to get rid of old ARP cache entries that would match our IP to the MAC used by the VM clone in a previous test. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
This process has several steps: - building of a data structure holding all of the answerfile data, from a customizable base in data.py and from tests-specific items - serialization as XML to be read by host-installer - necessary changes to the ISO for host-installer to use it We now have to explicitly enable the network during access (was implied by the use of a remote answerfile). Similarly we now rely on the test-pingpxe service, as nothing else would otherwise populate the server's ARP table. This is needed so: - different tests can use different parameters without the need for provisionning every answerfile to be used - tests can dynamically add contents for their own needs, before the XML gets actualy written Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
ydirson
force-pushed
the
install-rpu
branch
7 times, most recently
from
September 17, 2024 09:56
18dd346
to
91ca5c1
Compare
Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
When using --hosts=cache://... it is much too early for such a check, so we have to give the info manually, and the script would not allow this. And honor it not just for "collect".
ydirson
force-pushed
the
install-rpu
branch
5 times, most recently
from
September 18, 2024 12:45
79c5b0a
to
221f77d
Compare
Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
FIXME: dependency on tests from another module don't seem to get properly located by pytest-dependency (--ignore-unknown-dependency required)
FIXME: how useful?
FIXME: had to keep a copy of perform_upgrade() after its functionality was moved to vm_booted_with_installer fixture, must find a proper solution for that
Useful to get the debug output from commands.ssh() Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
ydirson
force-pushed
the
install-rpu
branch
from
September 18, 2024 13:49
221f77d
to
f573ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out and based on #226