Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert inheritance tests to match new xapi behavior #93

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

benjamreis
Copy link
Contributor

For XCP-ng > 8.2.1 there is a new behavior regarding SB certs management
See: xapi-project/xen-api#4659

Keep previous behavior for XCP-ng <= 8.2.1

Signed-off-by: BenjiReis benjamin.reis@vates.fr

@benjamreis
Copy link
Contributor Author

Tests successful for both > 8.2.1 and <= 8.2.1 on Alpine Debian10 and Windows 10

@benjamreis benjamreis force-pushed the new-xapi-uefi-certs-handling branch from 47c2927 to 7383161 Compare April 6, 2022 07:49
@benjamreis benjamreis requested a review from stormi April 6, 2022 07:49
@benjamreis benjamreis force-pushed the new-xapi-uefi-certs-handling branch from 7383161 to 10725c9 Compare April 6, 2022 08:01
Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a docstring to TestPoolToDiskCertInheritance explaining why there are two different behaviours in the tests, what's the old behaviour and what's the new one.

@benjamreis benjamreis force-pushed the new-xapi-uefi-certs-handling branch from a6ea46e to 3947471 Compare April 6, 2022 18:12
@benjamreis benjamreis requested a review from stormi April 6, 2022 18:12
For XCP-ng > 8.2.1 there is a new behavior regarding SB certs management
See: xapi-project/xen-api#4659

Keep previous behavior for XCP-ng <= 8.2.1

Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
@benjamreis benjamreis force-pushed the new-xapi-uefi-certs-handling branch from 3947471 to dc6dc7d Compare April 7, 2022 08:54
Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but let's wait for the XAPI PR to be merged before we merge this.

@stormi stormi self-requested a review April 8, 2022 08:58
Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
@benjamreis benjamreis force-pushed the new-xapi-uefi-certs-handling branch 2 times, most recently from 52b3ffe to efb3ce5 Compare April 8, 2022 13:40
lib/pool.py Outdated Show resolved Hide resolved
lib/pool.py Show resolved Hide resolved
tests/uefistored/test_cert_inheritance.py Outdated Show resolved Hide resolved
@stormi stormi self-requested a review April 8, 2022 13:54
@benjamreis benjamreis force-pushed the new-xapi-uefi-certs-handling branch 2 times, most recently from f05c448 to 2721f1e Compare April 8, 2022 14:09
- Create Host.join_pool and Pool.eject_host methods

Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
@benjamreis benjamreis force-pushed the new-xapi-uefi-certs-handling branch from 2721f1e to 254f409 Compare April 8, 2022 14:14
Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved... Now we still depend on the XAPI PR.

@benjamreis benjamreis merged commit c3c44b6 into master Apr 14, 2022
@benjamreis benjamreis deleted the new-xapi-uefi-certs-handling branch April 14, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants