-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cert inheritance tests to match new xapi behavior #93
Conversation
Tests successful for both > 8.2.1 and <= 8.2.1 on Alpine Debian10 and Windows 10 |
47c2927
to
7383161
Compare
7383161
to
10725c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a docstring to TestPoolToDiskCertInheritance explaining why there are two different behaviours in the tests, what's the old behaviour and what's the new one.
a6ea46e
to
3947471
Compare
For XCP-ng > 8.2.1 there is a new behavior regarding SB certs management See: xapi-project/xen-api#4659 Keep previous behavior for XCP-ng <= 8.2.1 Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
3947471
to
dc6dc7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but let's wait for the XAPI PR to be merged before we merge this.
Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
52b3ffe
to
efb3ce5
Compare
f05c448
to
2721f1e
Compare
- Create Host.join_pool and Pool.eject_host methods Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
2721f1e
to
254f409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved... Now we still depend on the XAPI PR.
For XCP-ng > 8.2.1 there is a new behavior regarding SB certs management
See: xapi-project/xen-api#4659
Keep previous behavior for XCP-ng <= 8.2.1
Signed-off-by: BenjiReis benjamin.reis@vates.fr