Use pure python code in place of os.system #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glehmann
force-pushed
the
gln/srpm-error-handling-wlnl
branch
from
a1f7b08 to
3782f97
Compare
stormi
approved these changes
Aug 6, 2025
glehmann
force-pushed
the
gln/srpm-error-handling-wlnl
branch
from
3782f97 to
5149284
Compare
psafont
reviewed
Aug 12, 2025
glehmann
force-pushed
the
gln/srpm-error-handling-wlnl
branch
from
5149284 to
2c59a22
Compare
psafont
approved these changes
Aug 13, 2025
ydirson
requested changes
Aug 25, 2025
scripts/import_srpm.py
Outdated
Comment on lines
30
to
32
| # to prevent deadlocks if the current process finishes before the previous one. | ||
| if last_process_stdout: | ||
| last_process_stdout.close() |
Contributor
There was a problem hiding this comment.
I'm not 100% sure of the nature of the deadlock, but avoiding keeping 2 readers on the pipe is definitely a good idea. Maybe describe it like "the new process does the reading from this pipe, drop our ref to it, notably preventing deadlocks"?
Member
Author
There was a problem hiding this comment.
I wrote that based on an example I found, but I can't produce any deadlock, and I find plenty of examples that don't use it. I'll remove it.
Contributor
There was a problem hiding this comment.
It should be kept, as explained (much better) in the API doc
os.system calls the user's shell, and is not directly checking for errors. This should raise an error when cpio or rpm2cpio fail, or if they can't be found. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/srpm-error-handling-wlnl
branch
from
2c59a22 to
fa8bab3
Compare
Member
ydirson
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.system calls the user's shell, and is not directly checking for errors. This should raise an error when cpio or rpm2cpio fail, or if they can't be found.