-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some updates for new CDS beta backend API #85
Conversation
These changes don't yet provide full support for the new API version (in part because the API server is in beta and it's not yet clear whether some of its new behaviours are planned changes or temporary bugs), but with them applied all but one of the unit tests pass. test_open_data_null_variables_list fails because the API server returns a Zip rather than the requested NetCDF. - Require cdsapi >=0.7.0 - Add an api_version parameter to ERA5DatasetHandler.__init__ (defaulting to 1). - Support new `data_format` parameter (replaces old `format`) in ERA5DatasetHandler - In CDSDataOpener, support both old and new ERA5 time coordinate names (`time` and `valid_time` respectively).
The open parameter |
- Bump minimum cdsapi version to 0.7.2 in environment.yml - Fix a typo in the readme - Remove a superfluous blank cell from an example notebook
I tried to invoke an error, when the dimension do not fit. However, the examples which produced errors last week, work fine now. I even added an example for ERA5, where I used parameters from atmosphere and ocean. The grid resolution of the ocean parameters is coarser by a factor of two. So far, I could not find an example, which gives me an error. I remember that |
@konstntokas I agree that it's enough if things are working with the current backend state and our current tests and use cases. We'll deal with any new errors or problems as and when they come up. Test suite and notebooks have now finally run to completion and code looks fine, so I'll approve and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I can't officially approve since it's still technically my PR, so I'll just merge :)
Closes #84 .
These changes don't yet provide full support for the new API version (in part because the API server is in beta and it's not yet clear whether some of its new behaviours are planned changes or temporary bugs), but with them applied all but one of the unit tests pass. test_open_data_null_variables_list fails because the API server returns a Zip rather than the requested NetCDF.
Require cdsapi >=0.7.0
Add an api_version parameter to ERA5DatasetHandler.init (defaulting to 1).
Support new
data_format
parameter (replaces oldformat
) in ERA5DatasetHandlerIn CDSDataOpener, support both old and new ERA5 time coordinate names (
time
andvalid_time
respectively).