Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #33

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Bug fixes #33

merged 3 commits into from
Mar 4, 2025

Conversation

konstntokas
Copy link
Collaborator

@konstntokas konstntokas commented Mar 4, 2025

  • Fixed a bug in "xcube-stac" for data_id="sentinel-2-l2a", where the filter intended to exclude items with invalid bounding boxes in STAC metadata was not functioning correctly.
  • Fixed a bug in "xcube-stac" for data_id="sentinel-2-l2a" where tiles crossing UTM zones were handled inconsistently due to different naming of the CRS variable stemming from xcube, depending on whether reprojection or simple resampling was applied.

@konstntokas konstntokas requested a review from forman March 4, 2025 13:47
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (9a3a754) to head (c70126e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          16       16           
  Lines        1179     1180    +1     
=======================================
+ Hits         1159     1160    +1     
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@konstntokas konstntokas changed the title Bug fixed for filtering wrong STAC items Bug fixes Mar 4, 2025
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the changelogs, otherwise find, I approve.

CHANGES.md Outdated


* CDSE Sentinel-2 Viewing Angle Dataset: The dimension of the viewing angle dataset
has been updated to `(time, angle, band, angle_y, angle_x)`.
* The package `_utils` has been made public and is now called `utils`.
* All data opener-specific open parameters are now consolidated into a single keyword
argument. This argument holds a dictionary where keys follow the structure
`<data_type>:<format_id>`.
`<data_type>:<format_id>`.
* Fixed a bug in `"xcube-stac"` for `data_id="sentinel-2-l2a"`, where the filter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed a bug in `"xcube-stac"` for `data_id="sentinel-2-l2a"`, where the filter
* Fixed a bug in data store `stac` when opening datasets for `data_id="sentinel-2-l2a"`, where the filter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And below as well.

@konstntokas konstntokas merged commit 9a47218 into main Mar 4, 2025
3 checks passed
@konstntokas konstntokas deleted the konstntokas-xxx-bux_fix_cdse_sen2_filter branch March 4, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants