-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes #33
Bug fixes #33
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 16 16
Lines 1179 1180 +1
=======================================
+ Hits 1159 1160 +1
Misses 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the changelogs, otherwise find, I approve.
CHANGES.md
Outdated
|
||
|
||
* CDSE Sentinel-2 Viewing Angle Dataset: The dimension of the viewing angle dataset | ||
has been updated to `(time, angle, band, angle_y, angle_x)`. | ||
* The package `_utils` has been made public and is now called `utils`. | ||
* All data opener-specific open parameters are now consolidated into a single keyword | ||
argument. This argument holds a dictionary where keys follow the structure | ||
`<data_type>:<format_id>`. | ||
`<data_type>:<format_id>`. | ||
* Fixed a bug in `"xcube-stac"` for `data_id="sentinel-2-l2a"`, where the filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Fixed a bug in `"xcube-stac"` for `data_id="sentinel-2-l2a"`, where the filter | |
* Fixed a bug in data store `stac` when opening datasets for `data_id="sentinel-2-l2a"`, where the filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And below as well.
"xcube-stac"
fordata_id="sentinel-2-l2a"
, where the filter intended to exclude items with invalid bounding boxes in STAC metadata was not functioning correctly."xcube-stac"
fordata_id="sentinel-2-l2a"
where tiles crossing UTM zones were handled inconsistently due to different naming of the CRS variable stemming from xcube, depending on whether reprojection or simple resampling was applied.