Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-defined variables #359

Merged
merged 28 commits into from
Jul 5, 2024
Merged

User-defined variables #359

merged 28 commits into from
Jul 5, 2024

Conversation

forman
Copy link
Member

@forman forman commented Jun 4, 2024

Added new dialog to define user variables for a selected dataset. Whenever user variables change, they are stored in the browsers local storage given the selected dataset's identifier and the list of associated user variables.

image

A user variable can be selected as any other variable. In the list of dataset variables they are marked with a special icon.

image

User variables should work with all viewer functionality. With a user variable selected, check

  • info panel
  • time-series panel
  • statistics panel
  • volume panel

Closes #371

Requires backend implementation xcube-dev/xcube#1021

@forman forman self-assigned this Jun 4, 2024
@forman forman marked this pull request as ready for review June 25, 2024 12:17
@konstntokas
Copy link
Contributor

What does min and max do? Is it the minimal and maximal values along the time axis? I have tried it out in the Viewer, but no data is shown.

@ruchimotwaniBC
Copy link
Contributor

ruchimotwaniBC commented Jul 3, 2024

What does min and max do? Is it the minimal and maximal values along the time axis? I have tried it out in the Viewer, but no data is shown.

True, I also have the same question :)
image

@ruchimotwaniBC
Copy link
Contributor

image

Since this variables are user defined and will not be found in the data, should we disable Volume tab for user defined variables or is it that we are explicitly showing this message to user?

Copy link
Contributor

@ruchimotwaniBC ruchimotwaniBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, else its working fine.

@forman
Copy link
Member Author

forman commented Jul 4, 2024

What does min and max do? Is it the minimal and maximal values along the time axis? I have tried it out in the Viewer, but no data is shown.

I have excluded min / max from the backend. Will do so for UI.

@forman
Copy link
Member Author

forman commented Jul 4, 2024

Since this variables are user defined and will not be found in the data, should we disable Volume tab for user defined variables or is it that we are explicitly showing this message to user?

That should be working now.

EDIT

That should be working using xcube-dev/xcube#1032

EDIT

That should be working now using xcube master branch.

@forman forman requested a review from ruchimotwaniBC July 4, 2024 12:12
@forman forman merged commit c87330d into main Jul 5, 2024
3 checks passed
@forman forman deleted the forman-user_variables branch July 5, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-defined variables
3 participants