-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve/document dependency discrepancies #945
Comments
Updates:
|
pont-us
added a commit
that referenced
this issue
Mar 15, 2024
These were commented as "required by Coiled", but this doesn't seem to be the case any more. Addresses #945.
pont-us
added a commit
that referenced
this issue
Mar 15, 2024
All xcube's dependencies are available in conda-forge, so the defaults channel is superfluous. Addresses #945.
pont-us
added a commit
that referenced
this issue
Mar 15, 2024
This commit mostly aligns the dependency list in environment.yml with actual imports in the codebase. Addresses #945. - Add botocore, cftime, and numcodecs. - Remove fontconfig, requests-oauthlib, and scipy.
6 tasks
pont-us
changed the title
Resolve/document dependency discrepancies in conda-forge releases
Resolve/document dependency discrepancies
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
conda-forge releases (e.g. here ) trigger a dependency analysis which always finds a significant number of discrepancies between the dependencies listed in
meta.yaml
. Automated dependency anaylsis isn't 100% reliable, but we should resolve as many of these as possible and document the rest so we don't waste time looking into them again. for the 1.4.1 release, the list is as follows:Packages found by source code inspection but not in the meta.yaml:
Packages found in the meta.yaml but not found by source code inspection:
cftime
numcodecs
botocore
werkzeug
scipy
adlfs
python-blosc
fontconfig
lz4
requests-oauthlib
Notes:
DEFAULT_DEPENDENCY_NAMES
inversions.py
.coiled
package, but thecoiled
package is only a soft dependency (i.e. we try to import locally at runtime if/when it's actually needed and raise an error if it's not available). If these are hard dependencies of coiled, we can probably omit them entirely: if coiled is importable, they must be present. If they're soft dependencies of coiled which we require for our use case, we should handle them the same way we handle thecoiled
package itself -- i.e. check at runtime if/when required.The text was updated successfully, but these errors were encountered: