Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get color mapping for variables with flag_values attribute #1012

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

forman
Copy link
Member

@forman forman commented Jun 7, 2024

Closes #1011

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman requested a review from konstntokas June 7, 2024 11:52
Copy link
Contributor

@konstntokas konstntokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo... See suggestion

cannot be created, e.g., ``flag_values`` are not defined.

Returns:
An suitable instance of ```matplotlib.colors.Colormap```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An suitable instance of ```matplotlib.colors.Colormap```
A suitable instance of ```matplotlib.colors.Colormap```

@forman forman marked this pull request as ready for review June 7, 2024 13:55
@forman forman merged commit 0db7aea into main Jun 7, 2024
1 of 2 checks passed
@forman forman deleted the forman-1011-cmap_in_mask_set branch June 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide color map for mask set with flag_values
2 participants