Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The xcube.core.store.DataDescriptor class now supports specifying time ranges using both datetime.date and datetime.datetime objects #1036

Merged
merged 3 commits into from
Jul 10, 2024
Merged

The xcube.core.store.DataDescriptor class now supports specifying time ranges using both datetime.date and datetime.datetime objects #1036

merged 3 commits into from
Jul 10, 2024

Conversation

konstntokas
Copy link
Contributor

@konstntokas konstntokas commented Jul 8, 2024 •
edited
Loading

closes #1031

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@konstntokas konstntokas requested a review from forman July 8, 2024 15:43
@konstntokas konstntokas force-pushed the konstntokas-1031-support_datetime_in_datadescriptor branch from 444bfa3 to e345bc5 Compare July 10, 2024 06:26
forman
forman approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@forman forman merged commit da0df9e into main Jul 10, 2024
2 of 3 checks passed
@konstntokas konstntokas deleted the konstntokas-1031-support_datetime_in_datadescriptor branch July 10, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forman forman forman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The class DataDescriptor may support datetime.datetime objects in the time_range
2 participants
@konstntokas @forman