Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forman 130 lazy load dataset details #131

Merged
merged 12 commits into from
Aug 7, 2019

Conversation

forman
Copy link
Member

@forman forman commented Jul 26, 2019

After merging this PR, xcube serve will behave differently:

  • The response of datasets?details=1 will now contain dataset descriptors, whose placeGroups GeoJSON feature collections will no longer have a features field.
  • Clients must therefore call datasets/{dataset}/places/{placeGroupId} to explicitly receive a place group including all GeoJSON features.

WARNING: Deploying new server instances will require to also deploy updated xcube-viewer instances. See xcube-dev/xcube-viewer#65 and xcube-dev/xcube-viewer#61

Closes #130.

@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #131 into master will decrease coverage by 0.17%.
The diff coverage is 68.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   85.64%   85.47%   -0.18%     
==========================================
  Files          71       71              
  Lines        6620     6665      +45     
==========================================
+ Hits         5670     5697      +27     
- Misses        950      968      +18
Impacted Files Coverage Δ
xcube/webapi/app.py 100% <ø> (ø) ⬆️
xcube/webapi/controllers/places.py 95.45% <100%> (+0.53%) ⬆️
xcube/webapi/controllers/catalogue.py 80.45% <29.16%> (-10.63%) ⬇️
xcube/webapi/handlers.py 90.46% <64.7%> (-1.72%) ⬇️
xcube/webapi/context.py 80.41% <78.68%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d7bea...e86f287. Read the comment docs.

Copy link
Contributor

@AliceBalfanz AliceBalfanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these changes be included into the CHANGES.md? Because there is an addition in the possibilities of regesting places?

@forman
Copy link
Member Author

forman commented Aug 6, 2019

Should these changes be included into the CHANGES.md?

Yes. It is an improvement.

Because there is an addition in the possibilities of regesting places?

I don't understand this.

@AliceBalfanz
Copy link
Contributor

Because there is an addition in the possibilities of regesting places?

I don't understand this.

Sorry, very bad English... What I meant to write: Shouldn't the changes be included in the CHANGES.md because amongst others there is a change of how places are requested, and the user should be aware of this change. But you already answered, that it should be included in the changes.md :)

@forman forman merged commit e06efb8 into master Aug 7, 2019
@forman forman deleted the forman-130-lazy_load_dataset_details branch August 7, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow lazy-loading of dataset details
3 participants