-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forman 130 lazy load dataset details #131
Conversation
# Conflicts: # xcube/webapi/context.py
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 85.64% 85.47% -0.18%
==========================================
Files 71 71
Lines 6620 6665 +45
==========================================
+ Hits 5670 5697 +27
- Misses 950 968 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these changes be included into the CHANGES.md? Because there is an addition in the possibilities of regesting places?
Yes. It is an improvement.
I don't understand this. |
Sorry, very bad English... What I meant to write: Shouldn't the changes be included in the CHANGES.md because amongst others there is a change of how places are requested, and the user should be aware of this change. But you already answered, that it should be included in the changes.md :) |
After merging this PR,
xcube serve
will behave differently:datasets?details=1
will now contain dataset descriptors, whoseplaceGroups
GeoJSON feature collections will no longer have afeatures
field.datasets/{dataset}/places/{placeGroupId}
to explicitly receive a place group including all GeoJSON features.WARNING: Deploying new server instances will require to also deploy updated xcube-viewer instances. See xcube-dev/xcube-viewer#65 and xcube-dev/xcube-viewer#61
Closes #130.