Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forman 141 optimize #146

Merged
merged 8 commits into from
Aug 13, 2019
Merged

Forman 141 optimize #146

merged 8 commits into from
Aug 13, 2019

Conversation

forman
Copy link
Member

@forman forman commented Aug 12, 2019

Addresses #141. After accepting this, xcube has

  1. a new CLI command xcube optimize [OPTIONS] INPUT
  2. a new API function xcube.api.optimize_dataset(input_path, ...)

@forman forman requested review from AliceBalfanz and dzelge August 12, 2019 12:46
@forman forman self-assigned this Aug 12, 2019
@forman forman changed the title Forman 141 consolidate Forman 141 optimize Aug 12, 2019
@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #146 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   85.62%   85.74%   +0.11%     
==========================================
  Files          72       75       +3     
  Lines        6743     6799      +56     
==========================================
+ Hits         5774     5830      +56     
  Misses        969      969
Impacted Files Coverage Δ
xcube/util/optimize.py 100% <100%> (ø)
xcube/api/__init__.py 100% <100%> (ø) ⬆️
xcube/util/unchunk.py 100% <100%> (ø)
xcube/cli/optimize.py 100% <100%> (ø)
xcube/cli/cli.py 91.72% <100%> (+0.12%) ⬆️
xcube/util/dsgrow.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a532cd...c490970. Read the comment docs.

Copy link
Contributor

@AliceBalfanz AliceBalfanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the documentation in the README.md, see DevGuide.
Appart from that, the optimize tool works very nicely, thank you for implementing!

@forman
Copy link
Member Author

forman commented Aug 13, 2019

Please add the documentation in the README.md, see DevGuide

Done!

@forman forman requested a review from AliceBalfanz August 13, 2019 10:43
Copy link
Contributor

@AliceBalfanz AliceBalfanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the README :)

@forman forman merged commit 5650f54 into master Aug 13, 2019
@forman forman deleted the forman-141-consolidate branch August 13, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants