Forman 222 rasterize features into dataset #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n' and 'lat' coords
addressing #222 with new function rasterize_features_into_dataset()
dzelge
approved these changes
Nov 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 86.12% 86.16% +0.04%
==========================================
Files 78 78
Lines 7453 7634 +181
==========================================
+ Hits 6419 6578 +159
- Misses 1034 1056 +22
Continue to review full report at Codecov.
|
Sag wo, ich mach das. |
dzelge
reviewed
Nov 11, 2019
| @@ -107,11 +107,11 @@ def test_get_dataset_indexes_without_bounds(self): | |||
| self._assert_get_dataset_indexes_works(dataset) | |||
|
|
|||
| def test_get_dataset_indexes_with_bounds_inverse_lat(self): | |||
There was a problem hiding this comment.
Suggested change
| def test_get_dataset_indexes_with_bounds_inverse_lat(self): | |
| def test_get_dataset_indexes_with_bounds_inverse_y(self): |
There was a problem hiding this comment.
lat is fine here, because get_dataset_indexes is still aware of lat, not y.
dzelge
reviewed
Nov 11, 2019
| @@ -107,11 +107,11 @@ def test_get_dataset_indexes_without_bounds(self): | |||
| self._assert_get_dataset_indexes_works(dataset) | |||
|
|
|||
| def test_get_dataset_indexes_with_bounds_inverse_lat(self): | |||
| dataset = new_cube(width=360, height=180, inverse_lat=True, drop_bounds=False) | |||
| dataset = new_cube(width=360, height=180, inverse_y=True, drop_bounds=False) | |||
| self._assert_get_dataset_indexes_works(dataset, inverse_lat=True) | |||
There was a problem hiding this comment.
Suggested change
| self._assert_get_dataset_indexes_works(dataset, inverse_lat=True) | |
| self._assert_get_dataset_indexes_works(dataset, inverse_y=True) |
dzelge
reviewed
Nov 11, 2019
| self._assert_get_dataset_indexes_works(dataset, inverse_lat=True) | ||
|
|
||
| def test_get_dataset_indexes_without_bounds_inverse_lat(self): | ||
| dataset = new_cube(width=360, height=180, inverse_lat=True, drop_bounds=True) | ||
| dataset = new_cube(width=360, height=180, inverse_y=True, drop_bounds=True) | ||
| self._assert_get_dataset_indexes_works(dataset, inverse_lat=True) | ||
|
|
||
| def _assert_get_dataset_indexes_works(self, dataset, inverse_lat=False): |
There was a problem hiding this comment.
Suggested change
| def _assert_get_dataset_indexes_works(self, dataset, inverse_lat=False): | |
| def _assert_get_dataset_indexes_works(self, dataset, inverse_y=False): |
dzelge
reviewed
Nov 11, 2019
| self._assert_get_dataset_indexes_works(dataset, inverse_lat=True) | ||
|
|
||
| def test_get_dataset_indexes_without_bounds_inverse_lat(self): | ||
| dataset = new_cube(width=360, height=180, inverse_lat=True, drop_bounds=True) | ||
| dataset = new_cube(width=360, height=180, inverse_y=True, drop_bounds=True) | ||
| self._assert_get_dataset_indexes_works(dataset, inverse_lat=True) |
There was a problem hiding this comment.
Suggested change
| self._assert_get_dataset_indexes_works(dataset, inverse_lat=True) | |
| self._assert_get_dataset_indexes_works(dataset, inverse_y=True) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xcube.core.geom.rasterize_features_into_dataset()xcube.core.new,xcube.core.geom,xcube.core.schema,xcube.core.verifyno longer depending on WGS84 CRS (lon/lat coordinates)