Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forman 272 computed vars #273

Merged
merged 6 commits into from
Feb 7, 2020
Merged

Forman 272 computed vars #273

merged 6 commits into from
Feb 7, 2020

Conversation

forman
Copy link
Member

@forman forman commented Feb 6, 2020

What's in here

The configuration of xcube serve has been enhanced to support augmentation of data cubes by new variables computed on-the-fly (#272). You can now add a section Augmentation into a dataset descriptor, e.g.:

Datasets:
  - Identifier: abc
    ...
    Augmentation:
        Path: compute_new_vars.py
        Function: compute_variables
        InputParameters:
            ...
  - ...

where compute_variables is a function that receives the parent xcube dataset and is expected to return a new dataset with new variables.

Note

I've enhanced the demo service configuration in examples/serve/demo/config.yml which now computes a new variable (a silly sum of CHL and TSM).

@forman forman added urgent High external pressure to address this ASAP important This is very important for the project CyanoAlert labels Feb 6, 2020
@forman forman requested review from AliceBalfanz and dzelge February 6, 2020 09:44
@forman forman self-assigned this Feb 6, 2020
@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #273 into master will decrease coverage by 0.25%.
The diff coverage is 75.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   84.44%   84.19%   -0.26%     
==========================================
  Files          84       85       +1     
  Lines        8765     8979     +214     
==========================================
+ Hits         7402     7560     +158     
- Misses       1363     1419      +56
Impacted Files Coverage Δ
xcube/webapi/app.py 100% <100%> (ø) ⬆️
xcube/webapi/errors.py 100% <100%> (ø) ⬆️
xcube/core/mldataset.py 63.46% <100%> (+0.14%) ⬆️
xcube/webapi/controllers/places.py 95.45% <100%> (ø) ⬆️
xcube/cli/serve.py 77.19% <50%> (+0.4%) ⬆️
xcube/webapi/context.py 77.31% <55.55%> (-5.28%) ⬇️
xcube/webapi/auth.py 86.48% <86.48%> (ø)
xcube/webapi/controllers/catalogue.py 84.86% <88.88%> (+0.42%) ⬆️
xcube/webapi/handlers.py 91.71% <90.9%> (+0.1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ddca1...1740e5a. Read the comment docs.

# Conflicts:
#	CHANGES.md
#	xcube/webapi/context.py
@forman forman merged commit 2216eb6 into master Feb 7, 2020
@forman forman deleted the forman-272-computed_vars branch February 16, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CyanoAlert important This is very important for the project urgent High external pressure to address this ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants